Skip to content

[vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix #9955 #12201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ras0219-msft merged 1 commit into from
Jul 2, 2020
Merged

[vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix #9955 #12201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions toolsrc/include/vcpkg/packagespec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ namespace vcpkg
///
struct PackageSpec
{
PackageSpec() noexcept = default;
PackageSpec(std::string name, Triplet triplet) : m_name(std::move(name)), m_triplet(triplet) { }
PackageSpec() = default;
PackageSpec(std::string name, Triplet triplet) : m_name(std::move(name)), m_triplet(triplet) {}

static std::vector<PackageSpec> to_package_specs(const std::vector<std::string>& ports, Triplet triplet);

Expand Down Expand Up @@ -54,7 +54,7 @@ namespace vcpkg
///
struct FeatureSpec
{
FeatureSpec(const PackageSpec& spec, const std::string& feature) : m_spec(spec), m_feature(feature) { }
FeatureSpec(const PackageSpec& spec, const std::string& feature) : m_spec(spec), m_feature(feature) {}

const std::string& name() const { return m_spec.name(); }
const std::string& feature() const { return m_feature; }
Expand Down Expand Up @@ -97,7 +97,7 @@ namespace vcpkg
PackageSpec package_spec;
std::vector<std::string> features;

FullPackageSpec() noexcept = default;
FullPackageSpec() = default;
explicit FullPackageSpec(PackageSpec spec, std::vector<std::string> features = {})
: package_spec(std::move(spec)), features(std::move(features))
{
Expand Down