Skip to content

[xerces-c] Fix invalid character in feature name#12184

Closed
jwillemsen wants to merge 35 commits intomicrosoft:masterfrom
jwillemsen:jwi-xercescfeature
Closed

[xerces-c] Fix invalid character in feature name#12184
jwillemsen wants to merge 35 commits intomicrosoft:masterfrom
jwillemsen:jwi-xercescfeature

Conversation

@jwillemsen
Copy link
Contributor

@jwillemsen jwillemsen commented Jul 1, 2020

  • What does your PR fix?

Fixes:

Error: :1:21: invalid character in feature name (must be lowercase, digits, '-')
on expression: xerces-c[xmlch_wchar]

    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/process_manager.patch:
      Added.

    * ports/ace/CONTROL:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/process_manager.patch:
    * ports/ace/portfile.cmake:
    * scripts/ci.baseline.txt:
    * ports/ace/CONTROL:
…wing error when using this feature:

Error: <unknown>:1:21: invalid character in feature name (must be lowercase, digits, '-')
   on expression: xerces-c[xmlch_wchar]
@jwillemsen
Copy link
Contributor Author

This error given by vcpkg is pretty new, our weekly build from last weekend didn't report it

@LilyWangL
Copy link
Contributor

Thanks for your PR. If disable-tests.patch usage and vcpkg-cmake-wrapper.cmake have nothing change, please don't modify them.

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Jul 2, 2020
    * ports/xerces-c/disable-tests.patch:
    * ports/xerces-c/vcpkg-cmake-wrapper.cmake:
    * ports/xerces-c/CONTROL:
    * ports/xerces-c/portfile.cmake:
    * ports/xerces-c/remove-dll-export-macro.patch:
    * ports/xerces-c/usage:
@jwillemsen
Copy link
Contributor Author

Created new PR #12205 to get rid of all non-related commits and the whitespace changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants