Skip to content

[libexif] Update to 0.6.22#12161

Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom
oskaritimperi:update-libexif-0622
Jul 6, 2020
Merged

[libexif] Update to 0.6.22#12161
ras0219-msft merged 3 commits intomicrosoft:masterfrom
oskaritimperi:update-libexif-0622

Conversation

@oskaritimperi
Copy link
Copy Markdown
Contributor

Describe the pull request

  • What does your PR fix?

Update libexif version from 0.6.21 to 0.6.22

From the release page on github:

It largely contains stability, security and bugfixes.

Some EXIF 2.3 tags have been added.

It is ABI compatible to 0.6.21 release.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No change.

Yes.

From the release page on github:

> It largely contains stability, security and bugfixes.
>
> Some EXIF 2.3 tags have been added.
>
> It is ABI compatible to 0.6.21 release.
@ghost
Copy link
Copy Markdown

ghost commented Jun 30, 2020

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown
Contributor

@c72578 c72578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In portfile.cmake:
include(vcpkg_common_functions) is deprecated.
Could you please remove this line.

Please change the following line:
file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/libexif RENAME copyright)
->
file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

- don't include vcpkg_commong_functions
- use the PORT variable when installing copyright file
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Jul 1, 2020
@NancyLi1013
Copy link
Copy Markdown
Contributor

@oswjk
Is this PR ready to merge now?

@c72578
Thanks for your help to review. It's so nice.

@oskaritimperi oskaritimperi marked this pull request as ready for review July 1, 2020 06:51
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 1, 2020
@ras0219-msft ras0219-msft merged commit d1a86d4 into microsoft:master Jul 6, 2020
@ras0219-msft
Copy link
Copy Markdown
Contributor

LGTM, thanks for the update!

@oskaritimperi oskaritimperi deleted the update-libexif-0622 branch August 3, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants