Skip to content

[simdjson] Update to 0.4.6#12140

Merged
ras0219-msft merged 14 commits intomicrosoft:masterfrom
myd7349:simdjson-v0.4.1
Jul 7, 2020
Merged

[simdjson] Update to 0.4.6#12140
ras0219-msft merged 14 commits intomicrosoft:masterfrom
myd7349:simdjson-v0.4.1

Conversation

@myd7349
Copy link
Copy Markdown
Contributor

@myd7349 myd7349 commented Jun 28, 2020 •
edited
Loading

Describe the pull request

@JackBoosY JackBoosY self-assigned this Jun 28, 2020
JackBoosY
JackBoosY suggested changes Jun 28, 2020
View reviewed changes
Comment thread ports/simdjson/portfile.cmake
@JackBoosY JackBoosY added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jun 28, 2020
@myd7349 myd7349 changed the title [simdjson] Update to 0.4.1 [simdjson] Update to 0.4.2 Jun 29, 2020
@myd7349 myd7349 marked this pull request as ready for review June 29, 2020 01:14
JackBoosY
JackBoosY suggested changes Jun 29, 2020
View reviewed changes
Comment thread scripts/ci.baseline.txt Outdated
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 29, 2020
@JackBoosY JackBoosY removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 30, 2020
@myd7349 myd7349 changed the title [simdjson] Update to 0.4.2 [simdjson] Update to 0.4.3 Jun 30, 2020
@myd7349 myd7349 changed the title [simdjson] Update to 0.4.3 [simdjson] Update to 0.4.4 Jun 30, 2020
@myd7349 myd7349 changed the title [simdjson] Update to 0.4.4 [simdjson] Update to 0.4.5 Jul 1, 2020
@myd7349 myd7349 force-pushed the simdjson-v0.4.1 branch from 467435c to 9737d90 Compare July 1, 2020 00:39
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Jul 1, 2020

Ready for review now?

@myd7349
Copy link
Copy Markdown
Contributor Author

myd7349 commented Jul 1, 2020

Ready for review now?

Yes.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 1, 2020
@myd7349 myd7349 mentioned this pull request Jul 4, 2020
Closed
@myd7349 myd7349 changed the title [simdjson] Update to 0.4.5 [simdjson] Update to 0.4.6 Jul 4, 2020
@myd7349
Copy link
Copy Markdown
Contributor Author

myd7349 commented Jul 4, 2020 •
edited
Loading

Hi! @JackBoosY Please review again. The upstream has issue several patch releases recently since v0.4.1, so I need to update this PR to keep up with the upstream.

JackBoosY
JackBoosY suggested changes Jul 6, 2020
View reviewed changes
Comment thread ports/simdjson/portfile.cmake
@ras0219-msft ras0219-msft merged commit e96a3bd into microsoft:master Jul 7, 2020
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Jul 7, 2020

LGTM, thanks for the PR!

@myd7349 myd7349 mentioned this pull request Jul 8, 2020
Closed
@myd7349 myd7349 deleted the simdjson-v0.4.1 branch July 8, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Microsoft vpkg to 0.4.2

3 participants

@myd7349 @JackBoosY @ras0219-msft