[vcpkg] Commonize pipelines build powershell and don't use binary caching in CI (rather than PR) builds#12082
Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom Jun 25, 2020
Conversation
BillyONeal
added
info:internal
category:infrastructure
Member
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
BillyONeal
force-pushed
the
ci_build_all_the_things
branch
from
661ce73 to
3c12065
Compare
…hing in CI (rather than PR) builds
BillyONeal
force-pushed
the
ci_build_all_the_things
branch
from
4e0f983 to
5416769
Compare
Contributor
|
I don't see where the CI gets batched. I think that a CI run gets kicked off for every new check-in, no? |
Member
Author
|
@cbezault It's in the trigger settings in the web interface:
|
Contributor
|
I think that can live in the yaml instead of in the interface but no complaints from me then. |
dan-shaw
reviewed
Jun 25, 2020
|
|
||
| $env:VCPKG_DOWNLOADS = Join-Path $WorkingRoot 'downloads' | ||
| $buildtreesRoot = Join-Path $WorkingRoot 'buildtrees' | ||
| $installRoot = Join-Path $WorkingRoot 'install' |
Contributor
There was a problem hiding this comment.
Should the installRoot be named installed?
dan-shaw
reviewed
Jun 25, 2020
| ) | ||
|
|
||
| if (-Not (Test-Path "triplets/$Triplet.cmake")) { | ||
| Write-Error 'Incorrect triplet, please supply a valid triplet.' |
Contributor
There was a problem hiding this comment.
Can we print out the name of the triplet?
dan-shaw
approved these changes
Jun 25, 2020
Contributor
dan-shaw
left a comment
dan-shaw
left a comment
There was a problem hiding this comment.
Some comments, otherwise LGTM
Member
Author
We use this same .yaml from both the PR pipeline and the CI pipeline, and those have different trigger settings, so it can't be in the yaml. |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…hing in CI (rather than PR) builds (microsoft#12082)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change obsoletes #11502 by making full rebuilds a normal part of our engineering process. Our CI builds are rolling: so even though this is typically going to take ~6-10 hours of machine time per triplet we build right now, it will batch up additional merged changes over that 6-10 hours and start again.
Hopefully this will give us a better understanding of ports that are flaky over time.