Conversation
|
isn't it better here and in #11836 to just rework the update mechanism and use not just CONTROL version, but also hashes like in CI to verify if update is necessary? |
|
Well, of course it would be better if the update mechanism checked changes in dependency CMake scripts in addition to CONTROL file. To build the dependency list it would most likely need the portfile's abstract syntax tree which afaik is not publicly accessible, although it should be possible to leverage CMake's sources and |
|
This PR is no longer required since vcpkg now has a heuristic which detects script changes. |
|
I think we don't need this PR now. |
|
AFAICT #12254 doesn't take into account transitive dependencies, such as |
Describe the pull request
Adds
tool-msysmetaport to updateMSYS2installation and rebuild the ports usingvcpkg_acquire_msyswhen the latter is changed (it's a maintainer's responsibility to increment the metaport's version when making changes tovcpkg_acquire_msys).Sets
<vcpkg>/downloadsdirectory as anMSYS2package cache to reuse them afterMSYS2updates.Additionally introduces
PORT_VERSIONvariable providing access to the version string from port'sCONTROLfile to CMake scripts.What does your PR fix?
Fixes [icu] build failure #11873
Which triplets are supported/not supported? Have you updated the CI baseline?
Not applicable.
Does your PR follow the maintainer guide?
Yes.
Waiting on #11836 to conclude, as it introduces a dependency metaport for
vcpkg_configure_makewhich itself is dependent onvcpkg_acquire_msys.