Skip to content

[vcpkg baseline] Retrigger failed port apr-util#11961

Closed
Septarius wants to merge 2 commits intomicrosoft:masterfrom
Septarius:apr-util-retrigger
Closed

[vcpkg baseline] Retrigger failed port apr-util#11961
Septarius wants to merge 2 commits intomicrosoft:masterfrom
Septarius:apr-util-retrigger

Conversation

@Septarius
Copy link
Contributor

Describe the pull request

Attempts to reproduce #11923 from master on the CI since I can't reproduce this locally (lack of an appropriate local OSX configuration).

  • What does your PR fix?

  • Which triplets are supported/not supported? Have you updated the CI baseline?

  • Does your PR follow the maintainer guide?

@Septarius
Copy link
Contributor Author

Failed OSX Check Run

@Septarius
Copy link
Contributor Author

Successful OSX Check Run
It is successful if apr and apr-util are built at the same time at least.

@JackBoosY JackBoosY self-assigned this Jun 16, 2020
@JackBoosY JackBoosY marked this pull request as ready for review June 16, 2020 01:19
@JackBoosY
Copy link
Contributor

Thanks for this PR!

@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jun 16, 2020
@BillyONeal
Copy link
Member

This just retriggers a build so I'd prefer to see it resolved by deleting the tombstone(s) for these ports. We should endeavor to make the port work consistently; if there's a consistent pattern of such failures we may need to skip these ports in CI.

@Septarius
Copy link
Contributor Author

@BillyONeal I was just attempting a repro case for the attached issue so let me know if you need anything from me.

@JackBoosY
Copy link
Contributor

JackBoosY commented Jun 16, 2020

Apr-util failure logs:

./../src/apr-util-1-a62665826e/configure: line 4089: cd: /Volumes/data/work/2/s/installed/x64-osx/build-1: No such file or directory

codes:

APR_BUILD_DIR="`cd $APR_BUILD_DIR && pwd`"

files:

vcpkg@VCPKG% ls packages/apr_x64-osx/build-1
apr_rules.mk            libtool                 make_exports.awk        make_var_export.awk     mkdir.sh

@JackBoosY JackBoosY added category:infrastructure Pertaining to the CI/Testing infrastrucutre and removed category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) labels Jun 23, 2020
@BillyONeal
Copy link
Member

I can't believe we have multiple ports trying to provide this "build-1" dir :(

@BillyONeal
Copy link
Member

Can you add an assertion that the directory in question build-1 doesn't exist before building the 'apr' port in addition to bumping the number?

Bumping the apr-util number is unnecessary: it's in the "cone of destruction" of apr so it will get rebuild automatically.

@JackBoosY
Copy link
Contributor

This issue occurs because apr-1.pc is not fixed. And I fixed it in #12067.

@BillyONeal
Copy link
Member

+1 @JackBoosY found the correct reason for the failure rather than Bill's supposition :)

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe #12067 will fix this

@Septarius
Copy link
Contributor Author

Sounds good to me, thanks for all the work on this! I will go ahead and close this PR. If you want you could add a fix tag for #11923 to #12067 since it should unblock the PRs mentioned in that issue as well.

@Septarius Septarius closed this Jun 24, 2020
@Septarius Septarius deleted the apr-util-retrigger branch June 26, 2020 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:infrastructure Pertaining to the CI/Testing infrastrucutre info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants