Skip to content

[marl] Repoint HEAD_REF to main#11953

Closed
ben-clayton wants to merge 1 commit intomicrosoft:masterfrom
ben-clayton:marl-main
Closed

[marl] Repoint HEAD_REF to main#11953
ben-clayton wants to merge 1 commit intomicrosoft:masterfrom
ben-clayton:marl-main

Conversation

@ben-clayton
Copy link
Copy Markdown

marl's default branch has been renamed from master to main.

See google/marl#153 for more details.

@PhoebeHui
Copy link
Copy Markdown
Contributor

@ben-clayton, thanks for your PR!

Could you update the Version to '2020-05-21-1' in CONTROL file?

@PhoebeHui PhoebeHui added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jun 16, 2020
@ben-clayton
Copy link
Copy Markdown
Author

Could you update the Version to '2020-05-21-1' in CONTROL file?

My understanding is that this should be adjusted if the package version / revision is actually changing - which in this case it is not. The SHA referenced is the same as before, I'm simply updating HEAD_REF to use the new name for the default branch, which is a direct mirror (same SHAs) of the old master branch.

I could be wrong though, so please let me know if I'm talking rubbish. :)

@PhoebeHui
Copy link
Copy Markdown
Contributor

@ben-clayton, sorry for the confuse.

If the port has been modified, we append a -N to distinguish the versions, it's not relate to SHA.

The default branch has been renamed from `master` to `main`.

See google/marl#153 for more details.
@ghost
Copy link
Copy Markdown

ghost commented Jun 17, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ ben-clayton sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@ben-clayton
Copy link
Copy Markdown
Author

I'm afraid I have to go through some red-tape to sign this CLA (not sure why this is check is kicking in only now).
If someone else wants to make this change on my behalf, I'd very much appreciate it.

myd7349 added a commit to myd7349/vcpkg that referenced this pull request Jun 30, 2020
[marl] Repoint HEAD_REF to `main` (microsoft#11953)

[marl] Dynamic build support
ras0219-msft pushed a commit that referenced this pull request Jul 6, 2020
* [marl] Update to 2020-06-30

[marl] Repoint HEAD_REF to `main` (#11953)

[marl] Dynamic build support

* [marl] Fix typo

* [marl] Add manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants