Skip to content

[tlx] Add new port (Need fixes)#11943

Merged
strega-nil merged 5 commits intomicrosoft:masterfrom
xahon:tlx
Aug 7, 2020
Merged

[tlx] Add new port (Need fixes)#11943
strega-nil merged 5 commits intomicrosoft:masterfrom
xahon:tlx

Conversation

@xahon
Copy link
Copy Markdown
Contributor

@xahon xahon commented Jun 15, 2020

Need help. When building project that links to that library an error occurs

D:\dev\test_tlx\out\build\x64-Release\ninja : error : 'D:/dev/tlx/out/build/x64-Debug (default)/tlx/tlx_debug.lib', needed by 'main.exe', missing and no known rule to make it

I think it is due to tlx_DIR variable is being set to D:/dev/tlx/out/build/x64-Debug (default) which is kind of invalid path but I don't know where that variable set

  1. When creating a shared library (dll) appropriate .lib file is not created

@ghost
Copy link
Copy Markdown

ghost commented Jun 15, 2020

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 16, 2020
Comment thread ports/tlx/portfile.cmake Outdated
Comment thread ports/tlx/CONTROL Outdated
Comment thread ports/tlx/portfile.cmake Outdated
xahon and others added 2 commits June 19, 2020 12:52
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@xahon
Copy link
Copy Markdown
Contributor Author

xahon commented Jun 19, 2020

It still throws an error during configuring time

Could not find a package configuration file provided by "tlx" with any of
1> [CMake] the following names:
1> [CMake]
1> [CMake] tlxConfig.cmake
1> [CMake] tlx-config.cmake

However, packages\tlx_x86-windows\share\tlx contains a lot of cmake files including tlx-config.cmake

Comment thread ports/tlx/portfile.cmake Outdated
@NancyLi1013
Copy link
Copy Markdown
Contributor

@xahon
You met the error when you used tlx?
Have you used it in your project like this?

find_package(tlx CONFIG REQUIRED)
target_link_libraries(main PRIVATE tlx)

Comment thread ports/tlx/portfile.cmake
@@ -0,0 +1,38 @@
vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
# TODO: Fix .dlls not producing .lib files
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can it not support dynamic build?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NancyLi1013 When dll is built there is no symbol resolution .lib file generated. Vcpkg prints a warning about it. I decided to make it first static, then someone will make it also able to build shared library in separate pr

@NancyLi1013
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Copy Markdown
Contributor

@xahon
Is there anything else needed to be done for this PR?

@NancyLi1013
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 7, 2020
@strega-nil strega-nil merged commit 728c549 into microsoft:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New Port Request] tlx

4 participants