[mingw] add VCPKG cmake_system_name#11934
Closed
MVoz wants to merge 9 commits intomicrosoft:masterfrom
MVoz:msys2_mingw_architecture
Closed
[mingw] add VCPKG cmake_system_name#11934MVoz wants to merge 9 commits intomicrosoft:masterfrom MVoz:msys2_mingw_architecture
MVoz wants to merge 9 commits intomicrosoft:masterfrom
MVoz:msys2_mingw_architecture
Conversation
c72578
reviewed
Jun 15, 2020
| case Identifier::android: return true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "Android"); | ||
| case Identifier::emscripten: return true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "Emscripten"); | ||
| case Identifier::wasm32: return true_if_exists_and_equal("VCPKG_TARGET_ARCHITECTURE", "wasm32"); | ||
| case Identifier::mingw: return true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "mingw"); |
Contributor
There was a problem hiding this comment.
true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "mingw")
->
true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "MinGW")
PhoebeHui
approved these changes
Jun 16, 2020
Contributor
PhoebeHui
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
BillyONeal
approved these changes
Jun 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logic
VCPKG_CMAKE_SYSTEM_NAME MinGW
vcpkg/triplets/community/x64-mingw.cmake
Line 6 in ffa7fd2
why is there no compiler definition? as in the example
https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/cross_compiling/Mingw
https://gitlab.kitware.com/cmake/community/uploads/265a703419aeaa26bef8044b92911e37/Toolchain-cross-mingw32-linux.cmake