[implot] Add new port#11920
Merged
ras0219-msft merged 8 commits intomicrosoft:masterfrom Jul 7, 2020
RT2Code:implot
Merged
Conversation
Contributor
|
Thanks for your PR. Now this port build failed with this error: |
Contributor
Author
Contributor
Author
|
Now that #11919 is merged, can you run the tests again? It should build now. :) |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@RT222 Now implot build failed on CI with the following error: Could you please continue to fix this PR? |
Contributor
Author
|
Sorry about that, it should be fixed now. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Hi, @RT222 Now implot build failed on Linux with the following error: |
Contributor
Author
|
It should now build on Linux as soon as #12155 is merged. |
Contributor
Author
|
#12155 have been merged, can you please run the tests again? It should build everywhere at last. :) |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
LGTM, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/epezent/implot
Requires #11919