Skip to content

[wlroots] Add new port#11913

Closed
handicraftsman wants to merge 9 commits intomicrosoft:masterfrom
handicraftsman:master
Closed

[wlroots] Add new port#11913
handicraftsman wants to merge 9 commits intomicrosoft:masterfrom
handicraftsman:master

Conversation

@handicraftsman
Copy link

Added wlroots port to vcpkg.

Only Linux-based triplets are supported because wlroots depends on libraries native to it.

I did not update ci-baseline yet, will do in next commit.

Please note that I patched meson build scripts to let them find vcpkg-provided packages (only pixman at the moment).

Also note that it depends on some system libraries like libdrm or x11 libraries (not sure yet, need to recheck configuration info).

@ghost
Copy link

ghost commented Jun 13, 2020

CLA assistant check
All CLA requirements met.

@handicraftsman handicraftsman marked this pull request as ready for review June 13, 2020 11:00
@handicraftsman
Copy link
Author

Sorry for all this mess, I should read nearby code more carefully from now.

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@PhoebeHui PhoebeHui added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Jun 15, 2020
@handicraftsman
Copy link
Author

Okay, will do, thanks for response.

@PhoebeHui
Copy link
Contributor

@BillyONeal, wlroots requires more libraries from the system, currently only linux VM required to install them, what's process for this now? could you help confirm?

Does the author need to update https://github.com/microsoft/vcpkg/blob/master/scripts/azure-pipelines/linux/provision-image.sh?

message("wlroots currently requires the following libraries from the system package manager:
wayland
wayland-protocols
EGL
GLESv2
libdrm
GBM
libinput
xkbcommon
udev
pixman
systemd (optional, for logind support)
elogind (optional, for logind support on systems without systemd)
If you choose to enable X11 support:

xcb
xcb-composite
xcb-xfixes
xcb-xinput
xcb-image
xcb-render
x11-xcb
xcb-errors (optional, for improved error reporting)
x11-icccm (optional, for improved Xwayland introspection)")

@BillyONeal
Copy link
Member

Yes, the author would need to edit the provisioning script to install the additional packages necessary, and then we would tag this PR "depends:vm-update". Then next time someone updates the image used for the Linux VMs they would make sure to collect all such changes to that script and do a deploy (example #11365).

@PhoebeHui
Copy link
Contributor

@BillyONeal, thanks for confirm this!

@handicraftsman, could you please also update scripts/azure-pipelines/linux/provision-image.sh?

@BillyONeal BillyONeal removed their assignment Jun 19, 2020
@LilyWangL
Copy link
Contributor

Pinging @handicraftsman for response, could you please also update scripts/azure-pipelines/linux/provision-image.sh?

@handicraftsman
Copy link
Author

There has been a new release of wlroots, so i am closing this (temporarily i think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants