Skip to content

[libosmium ] added new port#11863

Merged
dan-shaw merged 6 commits intomicrosoft:masterfrom
am2222:libosmium2
Jun 11, 2020
Merged

[libosmium ] added new port#11863
dan-shaw merged 6 commits intomicrosoft:masterfrom
am2222:libosmium2

Conversation

@am2222
Copy link
Contributor

@am2222 am2222 commented Jun 9, 2020

Describe the pull request

@am2222 am2222 marked this pull request as ready for review June 9, 2020 21:29
@am2222 am2222 changed the title added libosmium port [libosmium ] added new port Jun 9, 2020
@jremillard
Copy link

@am2222
Copy link
Contributor Author

am2222 commented Jun 10, 2020

I think the protozero is needed first. jremillard@db94c31

But that package has already added to the vcpkg. Here is its PR
#11652
But do we actually need this package for mapnik? on my machine it builds with no issues.

@LilyWangL LilyWangL added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Jun 10, 2020
@jremillard
Copy link

I can't see the logs for the automated checks?
@am2222, this package isn't needed for mapnik.

@LilyWangL
Copy link
Contributor

I can't see the logs for the automated checks?
@am2222, this package isn't needed for mapnik.

The CI x86-windows build log download URL: https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/38542/artifacts?artifactName=x64-windows-static%20port%20build%20failure%20logs&api-version=5.1&%24format=zip

@am2222
Copy link
Contributor Author

am2222 commented Jun 10, 2020

I can't see the logs for the automated checks?
@am2222, this package isn't needed for mapnik.

The CI x86-windows build log download URL: https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/38542/artifacts?artifactName=x64-windows-static%20port%20build%20failure%20logs&api-version=5.1&%24format=zip

Thanks, How can I download the logs for the other builds? I also have issue with mapnik's build but cannot access to build log.

@jremillard
Copy link

@am2222, the build failed because I forgot to add the boost dependency.

@am2222
Copy link
Contributor Author

am2222 commented Jun 10, 2020

@am2222, the build failed because I forgot to add the boost dependency.

Thanks. I added boost at dependencies. I think we had to define boost_root environment variable as well.

@am2222 am2222 requested a review from LilyWangL June 10, 2020 15:18
@jremillard
Copy link

I am not sure setting the boost_root env to the root of vcpkg is correct. The boost package should do that?

Copy link
Contributor Author

@am2222 am2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are applied

@LilyWangL LilyWangL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jun 11, 2020
@dan-shaw dan-shaw merged commit 0c9bc38 into microsoft:master Jun 11, 2020
JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
* added libosmium port

* minor fixes

* minor fixes

* Update CONTROL

* Update portfile.cmake

Co-authored-by: Lily <47812810+LilyWangL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants