Skip to content

[freetype] Update to 2.10.2#11846

Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom
kevinlul:freetype-2.10.2
Jul 8, 2020
Merged

[freetype] Update to 2.10.2#11846
ras0219-msft merged 4 commits intomicrosoft:masterfrom
kevinlul:freetype-2.10.2

Conversation

@kevinlul
Copy link
Contributor

@kevinlul kevinlul commented Jun 9, 2020

https://sourceforge.net/projects/freetype/files/freetype2/2.10.2/

Which triplets are supported/not supported? Have you updated the CI baseline?

Need to verify that removing patch 5 actually works for dynamic triplets like x86-windows and x64-windows. In the FreeType CMake, we have

if (WIN32)
  target_compile_definitions(
    freetype PRIVATE _CRT_SECURE_NO_WARNINGS _CRT_NONSTDC_NO_WARNINGS)
  if (BUILD_SHARED_LIBS)
    target_compile_definitions(
      freetype PRIVATE DLL_EXPORT)
  endif ()
endif ()

so there shouldn't be a need to patch in a custom flag for this.

Does your PR follow the maintainer guide? Yes

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added the category:port-update The issue is with a library, which is requesting update new revision label Jun 9, 2020
@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 11, 2020
@dan-shaw dan-shaw added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jun 11, 2020
@kevinlul kevinlul requested review from BillyONeal and dan-shaw June 12, 2020 02:03
@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kevinlul
Copy link
Contributor Author

Is there anything that I need to do? Maybe rebase onto current master? Though it looks like CI is failing on that too.

@LilyWangL
Copy link
Contributor

Waiting for #12067 merged, this PR will fix CI build error.

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants