-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[vcpkg/scripts/make] trying to iron out some issues #11836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3ccd4dd
a0907a1
0cf1aaa
4fcff6c
e9328fe
b9725d7
edf3b24
fc541db
ca25c71
3124ef9
a307a02
8093cf0
eb73911
1bab85b
22bb852
c3413e8
21487d6
35b0d29
c489dc1
d90ae98
9419320
95f4ceb
8be872d
4269503
d20fab1
a194ae9
315d92d
c4caa38
9718a36
c399f28
0a546dd
a7ce732
21e9617
06896bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| Source: farmhash | ||
| Version: 1.1-1 | ||
| Version: 1.1 | ||
| Port-Version: 2 | ||
| Homepage: https://github.com/google/farmhash | ||
| Description: FarmHash, a family of hash functions. | ||
| Supports: !arm |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| Source: freexl | ||
| Version: 1.0.4-9 | ||
| Version: 1.0.4 | ||
| Port-Version: 10 | ||
| Homepage: https://www.gaia-gis.it/gaia-sins/freexl-sources | ||
| Description: FreeXL is an open source library to extract valid data from within an Excel (.xls) spreadsheet | ||
| Build-Depends: libiconv |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| Source: libcrafter | ||
| Version: 0.3-1 | ||
| Version: 0.3 | ||
| Port-Version: 2 | ||
| Homepage: https://github.com/pellegre/libcrafter | ||
| Description: Libcrafter is a high level library for C++ designed to create and decode network packets. | ||
| Build-Depends: libpcap | ||
| Build-Depends: libpcap |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| Source: libmagic | ||
| Version: 5.37-1 | ||
| Version: 5.37 | ||
| Port-Version: 2 | ||
| Homepage: https://github.com/file/file | ||
| Description: This library can be used to classify files according to magic number tests. | ||
| Description: This library can be used to classify files according to magic number tests. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| Source: libwandio | ||
| Version: 4.2.1-2 | ||
| Version: 4.2.1 | ||
| Port-Version: 3 | ||
| Homepage: https://github.com/wanduow/wandio | ||
| Description: C library for simple and efficient file IO. | ||
| Build-Depends: zlib, zstd, liblzma, lz4, curl, pthread, bzip2 | ||
| Build-Depends: zlib, zstd, liblzma, lzo, lz4, curl, pthread, bzip2 | ||
| Supports: !windows | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| diff --git a/configure.ac b/configure.ac | ||
| index e250c0c31..0465120ba 100644 | ||
| --- a/configure.ac | ||
| +++ b/configure.ac | ||
| @@ -83,7 +83,7 @@ ADD_INCLS="" | ||
| ADD_LDFLAGS="$ADD_LDFLAGS -L\$(abs_top_srcdir)/lib" | ||
| LIBWANDIO_LIBS="" | ||
|
|
||
| -CFLAGS="$CFLAGS -Wall -Wmissing-prototypes -Wextra -DLT_BUILDING_DLL=1" | ||
| +CFLAGS="$CFLAGS -Wall -DLT_BUILDING_DLL=1 -DNOMINMAX" | ||
| -CXXFLAGS="$CXXFLAGS -Wall -DLT_BUILDING_DLL=1" | ||
| +CXXFLAGS="$CXXFLAGS -Wall -DLT_BUILDING_DLL=1 -DNOMINMAX" | ||
|
|
||
| # Check for -fvisibility |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| diff --git a/configure.ac b/configure.ac | ||
| index 4579fbb3d..f6be008c8 100644 | ||
| --- a/configure.ac | ||
| +++ b/configure.ac | ||
| @@ -296,12 +304,14 @@ AC_ARG_WITH([http], | ||
| AS_IF([test "x$with_http" != "xno"], | ||
| [ | ||
| # we need curl_easy_pause which was added in 7.18.0 | ||
| - AC_CHECK_LIB(curl, curl_easy_pause, have_curl=yes, have_curl=no) | ||
| + AC_SEARCH_LIBS(curl_easy_pause, [curl curl-d libcurl libcurl-d], have_curl=yes, have_curl=no, [-lCrypt32 -lWldap32 -lWs2_32 -ladvapi32]) | ||
| + # AC_CHECK_LIB(curl, curl_easy_pause, have_curl=yes, have_curl=no) | ||
| ], [have_curl=no]) | ||
|
|
||
| AS_IF([test "x$have_curl" = "xyes"], [ | ||
| - if test "$ac_cv_lib_curl_curl_easy_pause" != "none required"; then | ||
| - LIBWANDIO_LIBS="$LIBWANDIO_LIBS -lcurl" | ||
| + if test "$ac_cv_search_curl_easy_pause" != "none required"; then | ||
| + LIBWANDIO_LIBS="$LIBWANDIO_LIBS -lCrypt32 -lWldap32 -lWs2_32 -ladvapi32 $ac_cv_search_curl_easy_pause" | ||
| + LIBS="$LIBS" | ||
| fi | ||
| AC_DEFINE(HAVE_HTTP, 1, "Compiled with http support") | ||
| with_http=yes], |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| diff --git a/configure.ac b/configure.ac | ||
| index 4579fbb3d..f6be008c8 100644 | ||
| --- a/configure.ac | ||
| +++ b/configure.ac | ||
| @@ -296,12 +304,14 @@ AC_ARG_WITH([http], | ||
| AS_IF([test "x$with_http" != "xno"], | ||
| [ | ||
| # we need curl_easy_pause which was added in 7.18.0 | ||
| - AC_CHECK_LIB(curl, curl_easy_pause, have_curl=yes, have_curl=no) | ||
| + AC_SEARCH_LIBS(curl_easy_pause, [curl curl-d], have_curl=yes, have_curl=no, [-lssl -lcrypto $ac_cv_search_pthread_create -ldl]) | ||
| + # AC_CHECK_LIB(curl, curl_easy_pause, have_curl=yes, have_curl=no) | ||
| ], [have_curl=no]) | ||
|
|
||
| AS_IF([test "x$have_curl" = "xyes"], [ | ||
| - if test "$ac_cv_lib_curl_curl_easy_pause" != "none required"; then | ||
| - LIBWANDIO_LIBS="$LIBWANDIO_LIBS -lcurl" | ||
| + if test "$ac_cv_search_curl_easy_pause" != "none required"; then | ||
| + LIBWANDIO_LIBS="$LIBWANDIO_LIBS $ac_cv_search_curl_easy_pause -lssl -lcrypto $ac_cv_search_pthread_create -ldl" | ||
| + LIBS="$LIBS -lssl -lcrypto $ac_cv_search_pthread_create -ldl" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be fixed instead by producing PKG_CHECK_MODULES([CURL], [curl])
LIBS="$LIBS $CURL_LIBS"Based on my reading of https://autotools.io/pkgconfig/pkg_check_modules.html, the default action-if-not-found is to error out. Otherwise, we should
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be a proper fix but I did not want to touch this port any more than necessary. Because every dependency in libwandio would need that fix. If you want I can back out the patches to libwandio. |
||
| fi | ||
| AC_DEFINE(HAVE_HTTP, 1, "Compiled with http support") | ||
| with_http=yes], | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "lzokay", | ||
| "version-string": "2020-07-30", | ||
| "homepage": "https://github.com/jackoalan/lzokay", | ||
| "description": "lzokay – MIT licensed C++ implementation of LZO compression/decompression algorithm" | ||
| "description": "lzokay – MIT licensed C++ implementation of LZO compression/decompression algorithm", | ||
| "homepage": "https://github.com/jackoalan/lzokay" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| Source: ocilib | ||
| Version: 4.6.4-1 | ||
| Version: 4.6.4 | ||
| Port-Version: 2 | ||
| Homepage: https://vrogier.github.io/ocilib/ | ||
| Description: OCILIB is an open source and cross platform Oracle Driver that delivers efficient access to Oracle databases. | ||
| Supports: !(arm|uwp) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,64 @@ | ||
| vcpkg_fail_port_install(ON_ARCH "arm" ON_TARGET "uwp") | ||
|
|
||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO vrogier/ocilib | ||
| REF v4.6.4 | ||
| SHA512 83f5614a23c8fb4ab02517dec95d8b490c5ef472302735d5cc4cf483cc51513cc81ae2e1b4618c7c73fb5b071efe422e463b46fa79492ccb4775b511a943295a | ||
| HEAD_REF master | ||
| PATCHES | ||
| out_of_source_build_version_file_configure.patch | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO vrogier/ocilib | ||
| REF v4.6.4 | ||
| SHA512 83f5614a23c8fb4ab02517dec95d8b490c5ef472302735d5cc4cf483cc51513cc81ae2e1b4618c7c73fb5b071efe422e463b46fa79492ccb4775b511a943295a | ||
| HEAD_REF master | ||
| PATCHES | ||
| out_of_source_build_version_file_configure.patch | ||
| ) | ||
|
|
||
| if(VCPKG_TARGET_IS_WINDOWS) | ||
| if(VCPKG_PLATFORM_TOOLSET MATCHES "v142") | ||
| if(VCPKG_PLATFORM_TOOLSET MATCHES "v142") | ||
| set(SOLUTION_TYPE vs2019) | ||
| set(OCILIB_ARCH_X86 x86) | ||
| set(OCILIB_ARCH_X64 x64) | ||
| elseif(VCPKG_PLATFORM_TOOLSET MATCHES "v141") | ||
| elseif(VCPKG_PLATFORM_TOOLSET MATCHES "v141") | ||
| set(SOLUTION_TYPE vs2017) | ||
| set(OCILIB_ARCH_X86 Win32) | ||
| set(OCILIB_ARCH_X64 Win64) | ||
| else() | ||
| else() | ||
| set(SOLUTION_TYPE vs2015) | ||
| set(OCILIB_ARCH_X86 Win32) | ||
| set(OCILIB_ARCH_X64 Win64) | ||
| endif() | ||
| endif() | ||
|
|
||
| if(VCPKG_TARGET_ARCHITECTURE STREQUAL "x86") | ||
| set(PLATFORM ${OCILIB_ARCH_X86}) | ||
| else() | ||
| set(PLATFORM ${OCILIB_ARCH_X64}) | ||
| endif() | ||
| # There is no debug configuration | ||
| # As it is a C library, build the release configuration and copy its output to the debug folder | ||
| set(VCPKG_BUILD_TYPE release) | ||
| vcpkg_install_msbuild( | ||
| SOURCE_PATH ${SOURCE_PATH} | ||
| PROJECT_SUBPATH proj/dll/ocilib_dll_${SOLUTION_TYPE}.sln | ||
| INCLUDES_SUBPATH include | ||
| LICENSE_SUBPATH LICENSE | ||
| RELEASE_CONFIGURATION "Release - ANSI" | ||
| PLATFORM ${PLATFORM} | ||
| USE_VCPKG_INTEGRATION | ||
| ALLOW_ROOT_INCLUDES) | ||
| # There is no debug configuration | ||
| # As it is a C library, build the release configuration and copy its output to the debug folder | ||
| set(VCPKG_BUILD_TYPE release) | ||
| vcpkg_install_msbuild( | ||
| SOURCE_PATH ${SOURCE_PATH} | ||
| PROJECT_SUBPATH proj/dll/ocilib_dll_${SOLUTION_TYPE}.sln | ||
| INCLUDES_SUBPATH include | ||
| LICENSE_SUBPATH LICENSE | ||
| RELEASE_CONFIGURATION "Release - ANSI" | ||
| PLATFORM ${PLATFORM} | ||
| USE_VCPKG_INTEGRATION | ||
| ALLOW_ROOT_INCLUDES) | ||
|
|
||
| file(MAKE_DIRECTORY ${CURRENT_PACKAGES_DIR}/debug) | ||
| file(COPY ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/lib DESTINATION ${CURRENT_PACKAGES_DIR}/debug) | ||
| file(MAKE_DIRECTORY ${CURRENT_PACKAGES_DIR}/debug) | ||
| file(COPY ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/lib DESTINATION ${CURRENT_PACKAGES_DIR}/debug) | ||
| else() | ||
| vcpkg_configure_make( | ||
| SOURCE_PATH ${SOURCE_PATH} | ||
| OPTIONS | ||
| --with-oracle-import=runtime | ||
| ) | ||
| vcpkg_configure_make( | ||
| COPY_SOURCE | ||
| AUTOCONFIG | ||
Neumann-A marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| SOURCE_PATH ${SOURCE_PATH} | ||
| OPTIONS | ||
| --with-oracle-import=runtime | ||
| ) | ||
|
|
||
| vcpkg_install_make() | ||
| vcpkg_install_make() | ||
|
|
||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share) | ||
| file(RENAME ${CURRENT_PACKAGES_DIR}/share/doc/${PORT} ${CURRENT_PACKAGES_DIR}/share/${PORT}) | ||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/share/doc) | ||
| file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright) | ||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share) | ||
| file(RENAME ${CURRENT_PACKAGES_DIR}/share/doc/${PORT} ${CURRENT_PACKAGES_DIR}/share/${PORT}) | ||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/share/doc) | ||
| file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright) | ||
| endif() | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| Source: openmpi | ||
| Version: 4.0.3 | ||
| Port-Version: 2 | ||
| Homepage: https://www.open-mpi.org/ | ||
| Description: The Open MPI Project is an open source Message Passing Interface implementation that is developed and maintained by a consortium of academic, research, and industry partners. Open MPI is therefore able to combine the expertise, technologies, and resources from all across the High Performance Computing community in order to build the best MPI library available. Open MPI offers advantages for system and software vendors, application developers and computer science researchers. | ||
| Supports: !(windows|uwp) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| Source: pbc | ||
| Version: 0.5.14 | ||
| Port-Version: 3 | ||
| Build-Depends: mpir (windows), gmp(!windows) | ||
| Port-Version: 4 | ||
| Build-Depends: mpir (windows), gmp (!windows) | ||
| Homepage: https://crypto.stanford.edu/pbc | ||
| Description: Pairing-Based Crypto library provides low-level routines for pairing-based cryptosystems. | ||
| Supports: !uwp |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| Source: x264 | ||
| Version: 157-303c484ec828ed0-8 | ||
| Version: 157-303c484ec828ed0 | ||
| Port-Version: 9 | ||
| Homepage: https://github.com/mirror/x264 | ||
| Description: x264 is a free software library and application for encoding video streams into the H.264/MPEG-4 AVC compression format | ||
| Build-Depends: pthread (linux&osx) | ||
| Build-Depends: pthread (linux&osx) |
Uh oh!
There was an error while loading. Please reload this page.