Skip to content

[abseil] Enable dynamic build on Windows#11827

Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/abseil_enable_dynamic_win
Jun 11, 2020
Merged

[abseil] Enable dynamic build on Windows#11827
dan-shaw merged 3 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/abseil_enable_dynamic_win

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jun 8, 2020

Fixes #11820.

All features are tested successful in the following triplets:

  • x86-windows
  • x64-windows

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels Jun 8, 2020
@JackBoosY JackBoosY marked this pull request as ready for review June 8, 2020 09:25
@JackBoosY JackBoosY requested a review from PhoebeHui June 9, 2020 06:19
)

set(CMAKE_CXX_STANDARD )
set(CMAKE_CXX_STANDARD 11)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default setting in the source code is C++11.

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 9, 2020
@dan-shaw dan-shaw merged commit b0fbae8 into microsoft:master Jun 11, 2020
@JackBoosY JackBoosY deleted the dev/jack/abseil_enable_dynamic_win branch June 11, 2020 02:28
JangBoo pushed a commit to JangBoo/vcpkg that referenced this pull request Jun 18, 2020
* [abseil] Enable dynamic build on Windows

* re-fix arm build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[abseil] Enable building abseil as a shared library

3 participants