[vcpkg-acquire-msys] Improvement

[emptyVoid]

Describe the pull request

Drops a workaround introduced in #11443 as per a member of MSYS2 core packages are now once again use the original compression scheme supported by older versions of package manager (see msys2/MSYS2-packages#1962 (comment)).

Drops killing of gpg-agent.exe as GnuPG daemons are now being dealt with earlier in the script.

Removes updating of the package manager's database on package installs as the update could require a core system upgrade before some of the packages could be installed. Additionally this resolves a potential dependency conflict by ensuring all the MSYS2 dependent ports would get built against the same versions of MSYS2 packages.

• What does your PR fix?
  Fixes [ffmpeg] build failure #9427
  Fixes [vcpkg-acquire-msys] Update pacman before any other package. #11443 (comment)

• Which triplets are supported/not supported? Have you updated the CI baseline?
  Not applicable.

• Does your PR follow the maintainer guide?
  Yes.

@JackBoosY

[JackBoosY]

Could you update x264 version info to test this PR? See documentation.

[emptyVoid]

@JackBoosY, are you sure about x264? Although its logs will show if this PR works, it won't get built due to #11765.

There are a few other ports using vcpkg_configure_make which in turn utilizes vcpkg_acquire_msys on Windows: libb2, libcrafter, libmagic, libmesh, libwandio.

[JackBoosY]

@emptyVoid Therefore, you can select a port to test this PR.

[julianxhokaxhiu]

As you are on this already, is it possible to add an AppVeyor integration? At the current status, in order to use the existing msys2 installation I have to patch exactly this file at this line https://github.com/julianxhokaxhiu/ffmpegCI/blob/master/patch/scripts/cmake/vcpkg_acquire_msys.cmake#L39

If this could be configurable, it would be great. Or some kind of autodetection would be fine too.

Thank you in advance!

[emptyVoid]

Configurability of the MSYS2 installation definitely sounds beneficial for the user.

@julianxhokaxhiu, could you, please, create a feature request issue explaining your suggestion to may be discuss and gather some insights on the matter (I do have some ideas though I'm not sure if they are good to go).

[emptyVoid]

At the moment vcpkg_configure_make is broken for all the dependent packages:
#11765 - x264
#11832 - libb2, libmagic, libwandio
#11835 - libmesh
And libcrafter could not be built due to dependency: Target 'Windows' not supported by libpcap!

We could either wait for vcpkg_configure_make to be fixed, or could bump version in some other MSYS2 dependent port. @JackBoosY, what's your take on this?

[Neumann-A]

we have a hen egg problem:

-- Downloading https://sourceforge.net/projects/msys2/files/REPOS/MSYS2/x86_64/libzstd-1.4.4-2-x86_64.pkg.tar.xz/download...
-- Downloading https://sourceforge.net/projects/msys2/files/REPOS/MSYS2/x86_64/zstd-1.4.4-2-x86_64.pkg.tar.xz/download...
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:99 (message):


  File does not have expected hash:

          File path: [ D:/vcpkg_common/downloads/temp/zstd-1.4.4-2-x86_64.pkg.tar.xz ]
      Expected hash: [ 2be7e243d4e600d092aa6a630d24cfc536a6c06a4fa8e0909b0364569d2f938e24f220de1f52edbc36adc7c69ca23a2a730675f2da82c1530d3d91136089d3e2 ]
        Actual hash: [ 6d3ab3e9181b49a4afb747fe05d3a4965a170e37d68cb7cacafc07a79b9d22360609d26bc9fecad9a6f6d0ea30e743aa06dcef9c7d8a886028ad9ec6ca9f0558 ]

so I'll be merging this one into #11836

[emptyVoid]

That's most likely just a download issue -- stumbled on them a few times today, had to restart installs to make them go.

[julianxhokaxhiu]

@emptyVoid Issue created and linked to this PR :)

[JackBoosY]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JackBoosY]

Can you trigger the ffmpeg test by setting the ffmpeg version from 4.2-9 to 4.2-10?

[dan-shaw]

Thanks for the PR!