Skip to content

docs: fix CMakeLists example for SQLite3#11763

Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom
disposedtrolley:disposedtrolley/fix-cmake-sqlite-tutorial
Jun 5, 2020
Merged

docs: fix CMakeLists example for SQLite3#11763
ras0219-msft merged 3 commits intomicrosoft:masterfrom
disposedtrolley:disposedtrolley/fix-cmake-sqlite-tutorial

Conversation

@disposedtrolley
Copy link
Contributor

This PR modifies the CMakeLIsts.txt listing in the Installing and Using Packages Example: SQLite example doc to fix some build issues I was experiencing.

Without target_include_directories and linking to the ${SQLite3_LIBRARIES} variable instead of sqlite3 directly, cmake --build . errors with:

fatal error C1083: Cannot open include file: 'sqlite3.h': No such file or directory

@disposedtrolley disposedtrolley force-pushed the disposedtrolley/fix-cmake-sqlite-tutorial branch from ee60f3f to a2a3795 Compare June 4, 2020 01:43
@JackBoosY JackBoosY added category:documentation To resolve the issue, documentation will need to be updated requires:author-response labels Jun 4, 2020
@disposedtrolley disposedtrolley requested a review from JackBoosY June 4, 2020 03:58
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jun 4, 2020
@JackBoosY
Copy link
Contributor

Will rerun test after #11742 merged.

@dan-shaw
Copy link
Contributor

dan-shaw commented Jun 4, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft ras0219-msft merged commit 92db9a6 into microsoft:master Jun 5, 2020
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:documentation To resolve the issue, documentation will need to be updated info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants