[vcpkg] Track compiler information in ABI#11654
Merged
ras0219-msft merged 15 commits intomicrosoft:masterfrom Jun 22, 2020
Merged
[vcpkg] Track compiler information in ABI#11654ras0219-msft merged 15 commits intomicrosoft:masterfrom
ras0219-msft merged 15 commits intomicrosoft:masterfrom
Conversation
When binarycaching is not enabled, this warning is spurious and provides no user value.
Move several static global caches into VcpkgPaths/EnvCache. Add feature flag 'compilertracking' to enable the new feature.
Move VcpkgTripletVar into build.cpp because it is not used outside that file.
Neumann-A
reviewed
May 29, 2020
Contributor
|
Just a Note: We need to run CMake for every port which is not using CMake to actually get the correct compiler flags for the port using a given cmake toolchain anyway in the future. As such running this before the portfile could be beneficial. |
BillyONeal
reviewed
May 29, 2020
…compiler # Conflicts: # toolsrc/include/vcpkg/vcpkgpaths.h # toolsrc/src/vcpkg.cpp # toolsrc/src/vcpkg/build.cpp # toolsrc/src/vcpkg/vcpkgpaths.cpp
Contributor
Author
|
Currently waiting for #11785 |
JackBoosY
added
category:vcpkg-feature
…compiler # Conflicts: # toolsrc/include/vcpkg/globalstate.h # toolsrc/src/vcpkg.cpp # toolsrc/src/vcpkg/build.cpp # toolsrc/src/vcpkg/globalstate.cpp
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [vcpkg] Refactor out abi_tags_from_pre_build_info() * [vcpkg] Track Windows toolchain file in triplet hash * [vcpkg] Improve error messages when constructing PreBuildInfo * [vcpkg] Extract InstallPlanAction::BuildAbiInfo * [vcpkg] Extract Build::EnvCache and private-impl VcpkgPaths * [vcpkg] Enable compiler hash detection when binarycaching is enabled * [vcpkg] Downgrade warning about missing ABI keys When binarycaching is not enabled, this warning is spurious and provides no user value. * [vcpkg] Cleanup * [vcpkg] Refactor compiler tracking into triplet abi computation Move several static global caches into VcpkgPaths/EnvCache. Add feature flag 'compilertracking' to enable the new feature. * [vcpkg] Refactor out PreBuildInfo::using_vcvars() Move VcpkgTripletVar into build.cpp because it is not used outside that file. * [vcpkg] Address some code analysis warnings Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Tracking Compilers of the Binarycaching RFC (#11204).
The approach taken is to run a CMake configure in the environment that will be used to build packages and hash
CMAKE_CXX_COMPILERandCMAKE_C_COMPILER.This introduces an extra CMake configure step for every vcpkg invocation that requires ABI information -- as such, it is behind the feature flag
compilertracking(set VCPKG_FEATURE_FLAGS=compilertracking) until binarycaching is enabled by default.