Skip to content

[replxx] Add missing header <stdexcept> needed to name std::runtime_error for replxx.#11571

Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom
BillyONeal:update_replxx
May 27, 2020
Merged

[replxx] Add missing header <stdexcept> needed to name std::runtime_error for replxx.#11571
dan-shaw merged 2 commits intomicrosoft:masterfrom
BillyONeal:update_replxx

Conversation

@BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented May 25, 2020

Already applied upstream as AmokHuginnsson/replxx@723d9c8

  • What does your PR fix? Fixes build of replxx on Visual Studio 2019 version 16.6

@BillyONeal BillyONeal added the category:port-bug The issue is with a library, which is something the port should already support label May 25, 2020
@BillyONeal BillyONeal mentioned this pull request May 25, 2020
Merged
@cenit
Copy link
Contributor

cenit commented May 25, 2020

This stdexcept header issue with 16.6 is propagating in many ports. See also #11557

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 26, 2020
@BillyONeal
Copy link
Member Author

BillyONeal commented May 26, 2020

@cenit Sorry-not-sorry :) microsoft/STL#462 / microsoft/STL#482

@cenit
Copy link
Contributor

cenit commented May 26, 2020

it's perfectly fine.
Glad also to be able to inspect the reasons behind the scene. Love that STL is on GitHub and you guys are more involved also in vcpkg!

In a perfect world, you'd be testing also preview compilers here on vcpkg-CI, but I am sure you're already thinking about that!

@dan-shaw dan-shaw merged commit cff5795 into microsoft:master May 27, 2020
@BillyONeal BillyONeal deleted the update_replxx branch May 27, 2020 04:12
@BillyONeal
Copy link
Member Author

BillyONeal commented May 27, 2020

In a perfect world, you'd be testing also preview compilers here on vcpkg-CI

We are supposed to be doing that but:

(1) changes made to previews lock up ~3 months before you have a release in your hands; you can see that change was made in February but we're only seeing 16.6 out now.
(2) maybe something with that validation is on the floor (???)

Something for me to investigate soon with compiler folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BillyONeal @cenit @JackBoosY @dan-shaw