Skip to content

[pkg-config] Add new port#11523

Closed
Neumann-A wants to merge 6 commits intomicrosoft:masterfrom
Neumann-A:add_pkg_config
Closed

[pkg-config] Add new port#11523
Neumann-A wants to merge 6 commits intomicrosoft:masterfrom
Neumann-A:add_pkg_config

Conversation

@Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented May 22, 2020

Just for the fun of it. This is a native windows build and does not require msys on windows after build.

Probably requires the CI fixes for MSYS to build succesful?

c72578
c72578 reviewed May 22, 2020
View reviewed changes
c72578
c72578 reviewed May 22, 2020
View reviewed changes
c72578
c72578 reviewed May 22, 2020
View reviewed changes
@Neumann-A Neumann-A marked this pull request as ready for review May 22, 2020 14:08
@Neumann-A
Copy link
Contributor Author

Neumann-A commented May 24, 2020

Hmm wondering if this pkg-config build on windows can actually handle nativ windows paths. The msys version always requires converted unix like paths in PKG_CONFIG_PATH and also returns unix like paths if queried for -L paths.

@LilyWangL LilyWangL added category:new-port The issue is requesting a new library to be added; consider making a PR! category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) labels May 25, 2020
@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 25, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Jun 12, 2020

We have not really figured out how Vcpkg will acquire tools. Right now, the best way is to use vcpkg_find_acquire_program. I'm going to archive this PR for now, since we do not plan to build tools in Vcpkg yet. Please reopen if I'm missing something.

@dan-shaw dan-shaw closed this Jun 12, 2020
@Neumann-A
Copy link
Contributor Author

Neumann-A commented Jun 12, 2020

hmm now i need to extract the changes to vcpkg_configure_make.cmake and put them into #11836. Hoped i could get away with them ;)

@Neumann-A Neumann-A mentioned this pull request Jul 15, 2020
Merged
@Neumann-A Neumann-A mentioned this pull request Jul 29, 2020
Merged
@Neumann-A Neumann-A deleted the add_pkg_config branch November 18, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@c72578 c72578 c72578 left review comments

@LilyWangL LilyWangL LilyWangL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LilyWangL LilyWangL

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neumann-A @dan-shaw @c72578 @LilyWangL