Skip to content

[libvpx] Change default target on Unix#11500

Merged
strega-nil merged 6 commits intomicrosoft:masterfrom
kafeg:master
May 26, 2020
Merged

[libvpx] Change default target on Unix#11500
strega-nil merged 6 commits intomicrosoft:masterfrom
kafeg:master

Conversation

@kafeg
Copy link
Contributor

@kafeg kafeg commented May 21, 2020

Set default libvpx target to the 'x86_64-darwin17-gcc'. It's macOS 10.13 (High Sierra)

It's required to support the latest CPU features like hardware acceleration.

Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version info. See documentation.

@JackBoosY
Copy link
Contributor

Waiting for merge #11496.

@kafeg kafeg requested a review from JackBoosY May 22, 2020 07:59
@kafeg
Copy link
Contributor Author

kafeg commented May 22, 2020

Done

@JackBoosY
Copy link
Contributor

LGTM, thanks for this PR!

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 22, 2020
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably also do:

    set(LIBVPX_TARGET "--target=...")

and then instead of passing --target=${LIBVPX_TARGET}, pass ${LIBVPX_TARGET} so that on, say, FreeBSD, it still builds.

@kafeg kafeg requested a review from strega-nil May 24, 2020 09:36
@kafeg
Copy link
Contributor Author

kafeg commented May 26, 2020

You should probably also do:

    set(LIBVPX_TARGET "--target=...")

and then instead of passing --target=${LIBVPX_TARGET}, pass ${LIBVPX_TARGET} so that on, say, FreeBSD, it still builds.

Hey! I did it by another way, by set set(LIBVPX_TARGET "generic-gnu") # use default target

@strega-nil
Copy link
Contributor

Alright, cool, I'm happy with that. Thanks @kafeg :)

@strega-nil strega-nil merged commit b37f5d6 into microsoft:master May 26, 2020
@microsoft microsoft deleted a comment May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants