[libvpx] Change default target on Unix#11500
Merged
strega-nil merged 6 commits intomicrosoft:masterfrom May 26, 2020
kafeg:master
Merged
[libvpx] Change default target on Unix#11500strega-nil merged 6 commits intomicrosoft:masterfrom kafeg:master
strega-nil merged 6 commits intomicrosoft:masterfrom
kafeg:master
Conversation
JackBoosY
suggested changes
May 22, 2020
Contributor
JackBoosY
left a comment
There was a problem hiding this comment.
Please update the version info. See documentation.
Contributor
|
Waiting for merge #11496. |
Contributor
Author
|
Done |
JackBoosY
approved these changes
May 22, 2020
Contributor
|
LGTM, thanks for this PR! |
strega-nil
reviewed
May 23, 2020
strega-nil
reviewed
May 23, 2020
strega-nil
reviewed
May 23, 2020
strega-nil
reviewed
May 23, 2020
strega-nil
suggested changes
May 23, 2020
JackBoosY
approved these changes
May 26, 2020
Contributor
Author
Hey! I did it by another way, by set |
Contributor
|
Alright, cool, I'm happy with that. Thanks @kafeg :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set default libvpx target to the 'x86_64-darwin17-gcc'. It's macOS 10.13 (High Sierra)
It's required to support the latest CPU features like hardware acceleration.