[vtk] Added opengl feature.

[larshg]

Describe the pull request
Adds opengl feature.

Change description of feature: all.

• Which triplets are supported/not supported? Have you updated the CI baseline?
  all, no.
• Does your PR follow the maintainer guide?
  yes.

[NancyLi1013]

Could you please update this

file(COPY ${SOURCE_PATH}/Copyright.txt DESTINATION ${CURRENT_PACKAGES_DIR}/share/vtk)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/vtk/Copyright.txt ${CURRENT_PACKAGES_DIR}/share/vtk/copyright)

as
file(INSTALL ${SOURCE_PATH}/Copyright.txt DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)?

[larshg]

Updated.

[NancyLi1013]

Thanks for your update.
Needs to test the features now. I will update the test results once finished.

[NancyLi1013]

The feature tests are blocked by icu

warning: make-4.3-1 is up to date -- skipping
error: could not open file /var/cache/pacman/pkg/libgdbm-1.18.1-3-x86_64.pkg.tar.zst: Child process exited with status 127
error: could not open file /var/cache/pacman/pkg/gdbm-1.18.1-3-x86_64.pkg.tar.zst: Child process exited with status 127
error: failed to commit transaction (cannot open package file)

So we need to fix this issue #11438.

[NancyLi1013]

@larshg
The problem caused by icu has been resolved.
Could you please merge the latest commit to this PR?

[larshg]

Isn't a rebase the preferred way?

[NancyLi1013]

I will update this on my local to test features.
You won't merge it any more.

[NancyLi1013]

Hi @larshg
Sorry for the long delay.
Could you please look into the following problems?

The features build failed on x64-windows triplet:

The feature all is broken due to this:

CMake Error at CMake/vtkDownload.cmake:8 (message):
  Attempted to download Module_MomentInvariants when VTK_FORBID_DOWNLOADS is
  ON
Call Stack (most recent call first):
  CMake/vtkModuleRemote.cmake:142 (vtk_download_attempt_check)
  Remote/MomentInvariants.remote.cmake:5 (vtk_fetch_module)
  Remote/CMakeLists.txt:9 (include)

The feature qt, atlmfc, openvr ,paraview is broken due to this:

CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
  An external MPI-aware HDF5 requires that VTK be built with MPI support as
  well.

The feature python is broken due to this:

CMake Error at CMake/vtkModule.cmake:4140 (message):
  Could not find the Python3 external dependency.
Call Stack (most recent call first):
  Utilities/Python/CMakeLists.txt:49 (vtk_module_find_package)

The feature mpi is broken due to this:

CMake Error at CMake/vtkModule.cmake:959 (message):
  The VTK::IOParallelNetCDF module requires the disabled module VTK::mpi.
Call Stack (most recent call first):
  CMakeLists.txt:251 (vtk_module_scan)

[larshg]

All of those features seems to be unrelated to the opengl features? So those features has stopped working since VTK 9 was first added by @Neumann-A ?
I don't really have the time nor knowledge to look into these errors :(

[NancyLi1013]

@larshg

Thanks for your instant reply.

opengl is also broken due to this

-- Found OpenGL: opengl32  found components: OpenGL 
-- vtkDICOM: Building vtkDICOM as a Remote VTK Module
CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
  An external MPI-aware HDF5 requires that VTK be built with MPI support as
  well.

I will check this on the master later.

[Neumann-A]

-- vtkDICOM: Building vtkDICOM as a Remote VTK Module
CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
An external MPI-aware HDF5 requires that VTK be built with MPI support as
well.

VTK needs to pass -DVTK_GROUP_ENABLE_MPI=YES which it does:

if("mpi" IN_LIST FEATURES)
    list(APPEND ADDITIONAL_OPTIONS
        -DVTK_GROUP_ENABLE_MPI=YES
    )
endif()

Maybe we need to also pass -DVTK_USE_MPI=ON

[larshg]

I have just rebased on master an rebuild vtk[opengl] but didn't encounter any errors?

[JackBoosY]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[NancyLi1013]

@larshg
Feature opengl is broken on x64-windows:

-- vtkDICOM: Building vtkDICOM as a Remote VTK Module
CMake Error at ThirdParty/hdf5/CMakeLists.txt:26 (message):
  An external MPI-aware HDF5 requires that VTK be built with MPI support as
  well.

After add -DVTK_USE_MPI=ON, the error is like this:

CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "IONetCDF" links to target "MPI::MPI_C" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  IO/NetCDF/CMakeLists.txt:10 (vtk_module_add_module)


CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "IOParallelNetCDF" links to target "MPI::MPI_C" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  IO/ParallelNetCDF/CMakeLists.txt:14 (vtk_module_add_module)


CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "IOMINC" links to target "MPI::MPI_C" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  IO/MINC/CMakeLists.txt:15 (vtk_module_add_module)


CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "exodusII" links to target "MPI::MPI_C" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  ThirdParty/exodusII/vtkexodusII/CMakeLists.txt:300 (vtk_module_add_module)


CMake Error at F:/11399/vcpkg/scripts/buildsystems/vcpkg.cmake:252 (_add_library):
  Target "IOExodus" links to target "MPI::MPI_C" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMake/vtkModule.cmake:3328 (add_library)
  IO/Exodus/CMakeLists.txt:18 (vtk_module_add_module)

[larshg]

Do you install it with other features enabled as well? I'm on x64-windows and I don't encounter those errors?

[larshg]

[larshg]

Ah, maybe I haven't got an MPI-aware HDF5 installed...

[larshg]

This is my hdf5:

So this error is probably also present if you just try to install vtk without opengl feature?

[NancyLi1013]

I just try to install vck[opengl]:x64-windows, and it will fail due to the errors.

[larshg]

On a clean machine or do you have multiple features installed from hdf5 (specially the parallel feature which adds MPI).

[NancyLi1013]

I try to build it on a clean machine and there are no any errors on x64-windows.
Have you tested it on other triplets?

[larshg]

No, I work only on x64-windows with dynamic libraries.
I thought this is why we have CI's running various systems/configs :-)

[NancyLi1013]

Thanks for your update. I will continue to test other triplets.

[NancyLi1013]

Feature opengl has passed with the following triplets:

• x86-windows
• x64-windows
• x64-windows-static

Note: Other features are not changed.

[vicroms]

Thanks for the hard work!