Skip to content

Add MSVC Component Llvm ClangToolset to VM#11378

Closed
MVoz wants to merge 10 commits intomicrosoft:masterfrom
MVoz:Add-MSVC-Component-Llvm-ClangToolset
Closed

Add MSVC Component Llvm ClangToolset to VM#11378
MVoz wants to merge 10 commits intomicrosoft:masterfrom
MVoz:Add-MSVC-Component-Llvm-ClangToolset

Conversation

@MVoz
Copy link
Contributor Author

MVoz commented May 15, 2020

argument(s): "The directory is not empty.

error (x64_uwp) OR (arm_uwp) !?

@MVoz MVoz marked this pull request as ready for review May 15, 2020 13:22
@MVoz
Copy link
Contributor Author

MVoz commented May 15, 2020

example of using LLVM in another folder

<LLVMInstallDir>PATH_TO_LLVM</LLVMInstallDir>

msbuild /p:LLVMInstallDir="C:\Program Files (x86)\LLVM" /p:PlatformToolset="ClangCL"

@strega-nil strega-nil added the depends:vm-update PR contains changes to the VM provisioning scripts label May 15, 2020
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use case you intend to enable with this?

Add-MPPreference -ExclusionProcess python.exe

InstallVisualStudio -Workloads $Workloads -BootstrapperUrl $VisualStudioBootstrapperUrl -Nickname 'Stable'
InstallVisualStudio -includeRecommended -Workloads $Workloads -BootstrapperUrl $VisualStudioBootstrapperUrl -Nickname 'Stable'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates the liklihood of the installed bits changing a lot over time, so I don't think we should do that.

@MVoz
Copy link
Contributor Author

MVoz commented May 15, 2020

@BillyONeal
#11140

@MVoz
Copy link
Contributor Author

MVoz commented May 15, 2020

😕

@MVoz MVoz requested a review from BillyONeal May 16, 2020 12:07
@MVoz
Copy link
Contributor Author

MVoz commented May 19, 2020

the project apparently does not want to develop

@MVoz MVoz closed this May 19, 2020
@BillyONeal
Copy link
Member

@voskrese It isn't that 'we don't want to develop' -- I've been blocked from updating the VMs due to an unrelated issue. That's a heavy switch to flip since we need to get a clean baseline run when we do that. I've applied the install of LLVM over here: #11365

As for 'are we going to add that as a triplet', that's a different question. Given that we ship LLVM in the box though it might make sense. /cc @ras0219-msft @ras0219

@MVoz
Copy link
Contributor Author

MVoz commented May 19, 2020

ok

I needed only Microsoft.VisualStudio.Component.VC.Llvm.ClangToolset

but without the dependencies of Microsoft.VisualStudio.Component.VC.Llvm.Clang it won't install

triplet's - were for testing, and showing features

@BillyONeal
Copy link
Member

but without the dependencies of Microsoft.VisualStudio.Component.VC.Llvm.Clang it won't install

I observe the installer adding the right dependencies; I did this testing with 16.6. Rest assured when I get a VM update landed I'll make sure it's on the box

@MVoz
Copy link
Contributor Author

MVoz commented May 20, 2020

okey

@MVoz MVoz deleted the Add-MSVC-Component-Llvm-ClangToolset branch June 2, 2020 09:40
@BillyONeal
Copy link
Member

@voskrese I believe your VM changes landed in #11365

@BillyONeal BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants