Skip to content

[networkdirect] Add new port#11373

Closed
MVoz wants to merge 94 commits intomicrosoft:masterfrom
MVoz:add-azure-ci-wdk
Closed

[networkdirect] Add new port#11373
MVoz wants to merge 94 commits intomicrosoft:masterfrom
MVoz:add-azure-ci-wdk

Conversation

@MVoz
Copy link
Contributor

@MVoz MVoz commented May 15, 2020

deps
WDK + PlatformToolset=WindowsUserModeDriver10.0 (Vsix-WDK)

@MVoz MVoz marked this pull request as ready for review May 15, 2020 10:26
@cenit
Copy link
Contributor

cenit commented May 15, 2020

Fully agree with it. It might help moving msmpi port from binary to built from source

@BillyONeal BillyONeal added the depends:vm-update PR contains changes to the VM provisioning scripts label May 15, 2020
@BillyONeal
Copy link
Member

I'm a bit concerned with this because previously installing the WDK changed a whole bunch of machine-wide settings that broke folks (e.g. it tried to force everything to build with /Qspectre). But we'll see.

@MVoz
Copy link
Contributor Author

MVoz commented May 15, 2020

https://developercommunity.visualstudio.com/content/problem/348985/installing-wdk-1809-enabled-spectre-mitigation-fla.html

msbuild /p:SpectreMitigation=false

or patch

Removing the following:

<PropertyGroup>
<SpectreMitigation Condition="'$(SpectreMitigation)' == ''">Spectre</SpectreMitigation>
</PropertyGroup>

Microsoft.Cpp.WDK.props locates at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160 and subdirectories Platforms\(Platform name)\ImportBefore\Default

new version WDK.vsix only Kernel Driver ToolSets

    <Driver_SpectreMitigation Condition="'$(Driver_SpectreMitigation)' == ''">Spectre</Driver_SpectreMitigation>
    <SpectreMitigation>$(Driver_SpectreMitigation)</SpectreMitigation>

cmake 3.15+

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/3629/diffs

/Qspectre-

enable_language(C)

add_library(SpectreMitigationOn-C empty.c)
target_compile_options(SpectreMitigationOn-C PRIVATE -Qspectre)

add_library(SpectreMitigationOff-C empty.c)
target_compile_options(SpectreMitigationOff-C PRIVATE -Qspectre-)

https://github.com/CommonBuildToolset/CBT.Modules/blob/master/Directory.Build.rsp

add file Directory.Build.rsp

/p:SpectreMitigation=false

@BillyONeal
Copy link
Member

@voskrese That would require making such modifications to all ~1200 ports in inventory to inject that switch, which I don't think we want to sign up to do.

@MVoz
Copy link
Contributor Author

MVoz commented May 16, 2020

Spectre to false ?

@MVoz
Copy link
Contributor Author

MVoz commented May 16, 2020

version wdk 10.0.19582.0 no problem

WDK.zip

can use a newer version? as well as sdk

@MVoz
Copy link
Contributor Author

MVoz commented May 16, 2020

/p:SpectreMitigation=Disabled not work ))

v160\Microsoft.CppBuild.targets(436,5): error MSB8040: Spectre-mitigated libraries are required for this project. Install them from the Visual Studio installer (Individual components tab) for any toolsets and architectures being used. Learn more: https://aka.ms/Ofhn4c

@MVoz
Copy link
Contributor Author

MVoz commented May 16, 2020

version wdk 10.0.19041.1 no problem
work

@MVoz MVoz changed the title [vcpkg] addition Windows WDK to VM [NETWORKDIRECT] Add new port May 26, 2020
@MVoz
Copy link
Contributor Author

MVoz commented May 28, 2020

only test WDK, not merge

@BillyONeal BillyONeal changed the title [NETWORKDIRECT] Add new port [networkdirect] Add new port May 30, 2020
@MVoz MVoz closed this Jun 2, 2020
@MVoz MVoz deleted the add-azure-ci-wdk branch June 2, 2020 09:40
BillyONeal pushed a commit to BillyONeal/vcpkg that referenced this pull request Jun 11, 2020
@BillyONeal BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants