Skip to content

[sfml] Remove unnecessary patch#11246

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/remove_fsml_unnecessary_patch
May 8, 2020
Merged

[sfml] Remove unnecessary patch#11246
strega-nil merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/remove_fsml_unnecessary_patch

Conversation

@JackBoosY
Copy link
Contributor

When using cmake project, sfml will automaticlly export the used Windows library.
When using msvc project, Visual Studio will automatically add the library to INCLUDE_LIBRARIES.
So, this patch is unnecessary.

Related: #9190

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 8, 2020
@strega-nil
Copy link
Contributor

Alright, cool. Thanks @JackBoosY :)

@strega-nil strega-nil merged commit e179c4b into microsoft:master May 8, 2020
@JackBoosY JackBoosY deleted the dev/jack/remove_fsml_unnecessary_patch branch May 9, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants