[opencv4] Changed dependency on qt5 to qt5-base, closes microsoft/vcpkg#11138#11201
Merged
strega-nil merged 4 commits intomicrosoft:masterfrom May 8, 2020
Merged
Conversation
Contributor
Member
|
@NancyLi1013 I assume you meant bump -1 to -2 ? There's no -4 here... |
Contributor
|
can you please do the same change also in opencv3 and opencv2 packages? |
Contributor
opencv is the metapackage. It should be better to update the version of the opencv4 package too... |
Contributor
|
@BillyONeal and @cenit I meant we also needed to update the version for |
BillyONeal
force-pushed
the
feature/opencv4-fix-qt
branch
from
59c78fe to
494b50c
Compare
Member
|
Somehow I missed the 4 :) |
Contributor
Author
|
@BillyONeal bumped the version in opencv4, I made @cenit suggestion to make the same mods to opencv3 |
Contributor
|
If you merge your PR with master you can apply the same mod also to opencv2 |
venabled
force-pushed
the
feature/opencv4-fix-qt
branch
from
61fe86d to
3b583d5
Compare
NancyLi1013
approved these changes
May 8, 2020
NancyLi1013
added
info:needs-maintainer-attention
Contributor
|
Cools, thanks @venabled :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the circular dependency causing
CASCADED_DUE_TO_MISSING_DEPENDENCIESidentified by @cenit in #11138 by changing the dependency of theqtfeature fromqt5toqt5-baseWhat does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?