Skip to content

[vcpkg] Correctly record default feature list in BinaryParagraphs. Fixes #10678.#11085

Merged
cbezault merged 2 commits intomicrosoft:masterfrom
ras0219-msft:dev/roschuma/10678
Apr 29, 2020
Merged

[vcpkg] Correctly record default feature list in BinaryParagraphs. Fixes #10678.#11085
cbezault merged 2 commits intomicrosoft:masterfrom
ras0219-msft:dev/roschuma/10678

Conversation

@ras0219-msft
Copy link
Contributor

When determining the precise list of features requested by a particular package reference (FullPackageSpec in the code), the resolution algorithm must sometimes consult the list of default dependencies for the already installed package. This is because a reference such as cpprestsdk[compression] refers to the union of cpprestsdk's declared default features and the compression feature. In the case of depending upon an already installed package, we resolve defaults to the installed package's list until that package has been determined to need rebuilding.

Unfortunately, we were silently not recording the list of defaults for packages, which caused all references to default features in already installed packages to misbehave and not actually require any features.

  • What does your PR fix?

Fixes an underlying bug discovered in issue #10678. Users will need to rebuild all packages with default features to fully fix the problem. Requires also merging #11082 for a full resolution of @Ghabry's issue.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

N/A

Yes

@cbezault cbezault merged commit 9b91a53 into microsoft:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants