[idevicerestore] Fix libgen.h cannot be found

[NancyLi1013]

idevicerestore build error on x86-windows due to libgen.h cannot be found.

1>C:\agent\_work\1\s\buildtrees\idevicerestore\x86-windows-rel\1.0.12-cd5b5777d8\src\common.c(32,10): fatal error C1083: Cannot open include file: 'libgen.h': No such file or directory [C:\agent\_work\1\s\buildtrees\idevicerestore\x86-windows-rel\1.0.12-cd5b5777d8\idevicerestore.vcxproj]
         dfu.c
         download.c
 

Related PR #11003

Note: No feature needs to test.

[LilyWangL]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ras0219-msft]

Why does this PR cause libidevicerestore to fail on linux and osx?

[BillyONeal]

Indeed, it seems most important for this port to work on MacOS (given that it is a firmware restoration bit for iOS development).

[strega-nil]

Given the concerns pointed out by @ras0219-msft @BillyONeal, this needs more work; could you look at it after your holiday? Thanks!

[NancyLi1013]

Hi all,

Since idevicerestore depends on libimobiledevice to build. And libimobiledevice depends on libusbmuxd which currently can only build on windows.

idevicerestore should support all platforms. But currently, it cannot build on Linux and OSX. It is built via msbuild.

If we want to support Linux and OSX, we should fix the issue for libusbmuxd first. Then update the way to build idevicerestore.

[strega-nil]

how was it working before, then, on the CI?

[NancyLi1013]

I just added vcpkg_fail_port_install(ON_TARGET "linux" "osx") and

idevicerestore:x64-linux=fail
idevicerestore:x64-osx=fail

It should not be working on linux and osx before this, which will be blocked by libusbmuxd.

If necessary, I will remove the messages I added and try to build it again.

[strega-nil]

mmh, okay, I see. Alright, I think this is good then :)

[strega-nil]

Thanks @NancyLi1013 for pushing this forward!