[libxml2] Add iconv and charset linkage in vcpkg-cmake-wrapper on osx#11072
[libxml2] Add iconv and charset linkage in vcpkg-cmake-wrapper on osx#11072strega-nil merged 5 commits intomicrosoft:masterfrom
Conversation
| find_library(CHARSET_LIBRARY_RELEASE NAMES charset libcharset NAMES_PER_DIR PATH_SUFFIXES lib PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}" NO_DEFAULT_PATH) | ||
| find_library(CHARSET_LIBRARY_RELEASE NAMES charset libcharset NAMES_PER_DIR PATH_SUFFIXES lib) | ||
| select_library_configurations(ICONV) | ||
| select_library_configurations(CHARSET) |
There was a problem hiding this comment.
Is this due to we might use system iconv or within vcpkg on different platforms?
So we don't use find_package(unofficial-iconv to find iconv here?
There was a problem hiding this comment.
I try to avoid unofficial packages. The correct way would probably be to have pkg-config for iconv here but thats not yet integrated into vcpkg.
| if(CMAKE_SYSTEM_NAME STREQUAL "Linux") | ||
| list(APPEND LIBXML2_LIBRARIES m) | ||
| else() | ||
| list(APPEND LIBXML2_LIBRARIES ${ICONV_LIBRARIES} ${CHARSET_LIBRARIES}) |
There was a problem hiding this comment.
Is iconv only required on Windows and osx platform?
There was a problem hiding this comment.
At least it looks like libxml is not linking against iconv on Linux or is linking against a shared version which does not require propagation. The correct fix would probably to make iconv build on all platforms and linking correctly against that.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Neumann-A |
…c_linkage # Conflicts: # scripts/ci.baseline.txt
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
added
the
info:needs-maintainer-attention
|
This looks great! Thanks @Neumann-A :) |
4 participants
closes #11001
makes #10770 work on osx