[vcpkg] Small touchups for vcpkg unit tests#11068
Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom Apr 29, 2020
horenmar:dev-small-testing-fixes
Merged
[vcpkg] Small touchups for vcpkg unit tests#11068ras0219-msft merged 2 commits intomicrosoft:masterfrom horenmar:dev-small-testing-fixes
ras0219-msft merged 2 commits intomicrosoft:masterfrom
horenmar:dev-small-testing-fixes
Conversation
The tests are trivial enough that it is unlikely to come useful, but the old usage is bad practice.
This should prevent committing tests that are run-order dependent, or at least shake them out eventually in CI.
cbezault
approved these changes
Apr 28, 2020
BillyONeal
approved these changes
Apr 29, 2020
Contributor
|
LGTM, thanks @horenmar for the drive-by fixes! |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* Do not disable expression decomposition in some optional tests The tests are trivial enough that it is unlikely to come useful, but the old usage is bad practice. * Run tests in random order This should prevent committing tests that are run-order dependent, or at least shake them out eventually in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This improve vcpkg's unit tests a bit, per conversation with @strega-nil.
Optionaltests