[prefab-export] do not try to copy headers if the directory does not exist.#11055
Closed
atsushieno wants to merge 1 commit intomicrosoft:masterfrom
Closed
[prefab-export] do not try to copy headers if the directory does not exist.#11055atsushieno wants to merge 1 commit intomicrosoft:masterfrom
atsushieno wants to merge 1 commit intomicrosoft:masterfrom
Conversation
atsushieno
changed the title
Author
|
Actually there was another place to apply the same fix. Creating amended PR. |
atsushieno
force-pushed
the
prefab-export-check-header-dir
branch
from
972edaf to
1e40a06
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@atsushieno @NancyLi1013 @LilyWangL I don't know if this is the right fix as the issue is not related to headers but rather a misconfig on the user's side. I could be wrong. But checkout my comment |
Author
Contributor
|
@atsushieno You can close this if your issue was resolved |
Author
|
Okay, I assume that those directories should exist if we specify the right target and have appropriate triplets, and any ambiguous outputs should be tracked at #11052. At least this "fix" does not bring any good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Partly fixes #11052
This fixes the actual Android build issue; the packaging step does not abort in the middle.
Not applicable; it is about the latest Android support and there is no android triplets defined yet in this repository.
It should (but it is first time contribution so any surprise could happen).