Skip to content

[cpprestsdk] Update to v2.10.16#11018

Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom
BillyONeal:update_cpprestsdk
Apr 30, 2020
Merged

[cpprestsdk] Update to v2.10.16#11018
BillyONeal merged 5 commits intomicrosoft:masterfrom
BillyONeal:update_cpprestsdk

Conversation

@BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Apr 25, 2020

No description provided.

@LilyWangL LilyWangL self-requested a review April 26, 2020 02:02
@LilyWangL LilyWangL self-assigned this Apr 26, 2020
LilyWangL
LilyWangL suggested changes Apr 26, 2020
View reviewed changes
@LilyWangL
Copy link
Contributor

LilyWangL commented Apr 26, 2020

The way to handle feature can be replaced by vcpkg_check_features().

set(CPPREST_EXCLUDE_BROTLI ON)
if ("brotli" IN_LIST FEATURES)
    set(CPPREST_EXCLUDE_BROTLI OFF)
endif()
set(CPPREST_EXCLUDE_COMPRESSION ON)
if ("compression" IN_LIST FEATURES)
    set(CPPREST_EXCLUDE_COMPRESSION OFF)
endif()
set(CPPREST_EXCLUDE_WEBSOCKETS ON)
if("websockets" IN_LIST FEATURES)
    set(CPPREST_EXCLUDE_WEBSOCKETS OFF)
endif()

@ras0219-msft
Copy link
Contributor

ras0219-msft commented Apr 27, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 27, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal requested a review from LilyWangL April 27, 2020 19:01
@BillyONeal
Copy link
Member Author

BillyONeal commented Apr 27, 2020

@ras0219-msft Thanks for resolving the CR feedback!

@JackBoosY JackBoosY mentioned this pull request Apr 28, 2020
Merged
@LilyWangL LilyWangL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed needs-further-review labels Apr 28, 2020
cbezault
cbezault reviewed Apr 28, 2020
View reviewed changes
ports/cpprestsdk/CONTROL
Version: 2.10.16
Build-Depends: openssl (!uwp&!windows), boost-system (!uwp&!windows),
boost-date-time (!uwp&!windows), boost-regex (!uwp&!windows), boost-thread (!uwp&!windows),
boost-filesystem (!uwp&!windows), boost-random (!uwp&!windows), boost-chrono (!uwp&!windows),
Copy link
Contributor

@cbezault cbezault Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, I think default features can take qualifiers now.

@BillyONeal BillyONeal merged commit 2bc6cd7 into microsoft:master Apr 30, 2020
@BillyONeal BillyONeal deleted the update_cpprestsdk branch April 30, 2020 07:46
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Apr 30, 2020
@Jimmy-Hu
Merge pull request #194 from microsoft/master
4f12651 
[cpprestsdk] Update to v2.10.16 (microsoft#11018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cbezault cbezault cbezault left review comments

@LilyWangL LilyWangL LilyWangL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LilyWangL LilyWangL

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BillyONeal @LilyWangL @ras0219-msft @cbezault