Skip to content

[libvmdk] Initial port#11010

Merged
strega-nil merged 2 commits intomicrosoft:masterfrom
VelocityRa:libvmdk
May 18, 2020
Merged

[libvmdk] Initial port#11010
strega-nil merged 2 commits intomicrosoft:masterfrom
VelocityRa:libvmdk

Conversation

@VelocityRa
Copy link
Contributor

@VelocityRa VelocityRa commented Apr 24, 2020

Based on #6852.

@msftclas
Copy link

msftclas commented Apr 24, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@VelocityRa
Copy link
Contributor Author

VelocityRa commented Apr 24, 2020 •
edited
Loading

Volumes/data/work/1/s/buildtrees/libvmdk/src/20191221-5d3ea3bc22/libclocale/libclocale_support.c:26:10: fatal error: 'libintl.h' file not found
Volumes/data/work/1/s/buildtrees/libvmdk/src/20191221-5d3ea3bc22/libcfile/libcfile_file.c:67:10: fatal error: 'linux/fs.h' file not found

Why do HAVE_LIBINTL_H and HAVE_LINUX_FS_H get defined on macOS despite their respective headers missing?

@VelocityRa
Copy link
Contributor Author

VelocityRa commented Apr 24, 2020 •
edited
Loading

Would patching out the #includes on macOS be accepted if it works?
I don't really know why this happens so I can't implement another solution.

@VelocityRa
Copy link
Contributor Author

VelocityRa commented Apr 24, 2020

Adding gettext to Build-Depends fixed the libintl issue.

@VelocityRa VelocityRa force-pushed the libvmdk branch 2 times, most recently from 6835dc4 to 31debb9 Compare April 25, 2020 15:25
@VelocityRa VelocityRa marked this pull request as ready for review April 25, 2020 15:26
@VelocityRa VelocityRa changed the title [libvmdk] Add new port [libvmdk] Initial port Apr 25, 2020
@VelocityRa
Copy link
Contributor Author

VelocityRa commented Apr 25, 2020 •
edited
Loading

Maintainers, any help? This CI error is unrelated to my PR (happens on macOS).

-- Downloading https://jaist.dl.sourceforge.net/project/geographiclib/distrib/archive/GeographicLib-1.47-patch1.zip...
-- Downloading https://jaist.dl.sourceforge.net/project/geographiclib/distrib/archive/GeographicLib-1.47-patch1.zip... Failed. Status: 7;"Couldn't connect to server"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:175 (message):
      
      Failed to download file.
      If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
      variables to "https://user:password@your-proxy-ip-address:port/".
      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  ports/geographiclib/portfile.cmake:3 (vcpkg_download_distfile)
  scripts/ports.cmake:90 (include)

@VelocityRa VelocityRa mentioned this pull request Apr 25, 2020
Closed
@LilyWangL LilyWangL requested a review from NancyLi1013 April 26, 2020 02:00
NancyLi1013
NancyLi1013 suggested changes Apr 26, 2020
View reviewed changes
@VelocityRa
Copy link
Contributor Author

VelocityRa commented Apr 26, 2020

Squashed commits.

@VelocityRa VelocityRa force-pushed the libvmdk branch 2 times, most recently from 8831f4a to cfcdd90 Compare April 26, 2020 17:19
NancyLi1013
NancyLi1013 suggested changes Apr 27, 2020
View reviewed changes
@VelocityRa
Copy link
Contributor Author

VelocityRa commented Apr 27, 2020

Done.

@JackBoosY JackBoosY mentioned this pull request Apr 28, 2020
Merged
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 30, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 30, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@VelocityRa
Copy link
Contributor Author

VelocityRa commented May 2, 2020

Tests pass.

@VelocityRa VelocityRa requested a review from NancyLi1013 May 2, 2020 20:34
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented May 6, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 6, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

JackBoosY commented May 6, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 6, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented May 8, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 8, 2020

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY
JackBoosY suggested changes May 9, 2020
View reviewed changes
@JackBoosY
Copy link
Contributor

JackBoosY commented May 14, 2020

Pinging @VelocityRa for response. Is work still being done for this PR?

@VelocityRa
Copy link
Contributor Author

VelocityRa commented May 14, 2020

the line you told me to delete resulted in CI failing

NancyLi1013
NancyLi1013 reviewed May 15, 2020
View reviewed changes
@VelocityRa
[libvmdk] Initial port
c1b9773 
Signed-off-by: Nick Renieris <velocityra@gmail.com>
@VelocityRa VelocityRa force-pushed the libvmdk branch 2 times, most recently from 2437ffa to c1b9773 Compare May 15, 2020 13:47
@VelocityRa
Copy link
Contributor Author

VelocityRa commented May 15, 2020

that's why i had disabled static. it fails with that weird error

JackBoosY
JackBoosY suggested changes May 18, 2020
View reviewed changes
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 18, 2020
@strega-nil
Copy link
Contributor

strega-nil commented May 18, 2020

Alright, this looks good to me! Thanks so much @VelocityRa :)

@strega-nil strega-nil merged commit 9f0f0bd into microsoft:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VelocityRa @msftclas @NancyLi1013 @JackBoosY @strega-nil