Skip to content

[metrohash] installation fix#10992

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
kreuzerkrieg:metrohash-install-fix
May 1, 2020
Merged

[metrohash] installation fix#10992
strega-nil merged 1 commit intomicrosoft:masterfrom
kreuzerkrieg:metrohash-install-fix

Conversation

@kreuzerkrieg
Copy link
Contributor

Fixing paths and configuration

@LilyWangL LilyWangL self-assigned this Apr 24, 2020
@LilyWangL LilyWangL changed the title metrohash installation fix [metrohash] installation fix Apr 24, 2020
@LilyWangL
Copy link
Contributor

Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md.

@kreuzerkrieg
Copy link
Contributor Author

Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md.

Done

@kreuzerkrieg
Copy link
Contributor Author

Please do not merge, more changes to come

@kreuzerkrieg kreuzerkrieg force-pushed the metrohash-install-fix branch from 9bfbcf6 to 360f2f7 Compare April 24, 2020 17:45
@kreuzerkrieg
Copy link
Contributor Author

Ok, looks good now
Please review

@LilyWangL LilyWangL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Apr 26, 2020
@strega-nil
Copy link
Contributor

LGTM! Thanks @kreuzerkrieg :)

@strega-nil strega-nil merged commit bdb7b81 into microsoft:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants