Skip to content

[boost-locale] Fix boost-locale failing to build with ICU#10943

Merged
BillyONeal merged 6 commits intomicrosoft:masterfrom
Victor-Bergman:master
Jun 30, 2020
Merged

[boost-locale] Fix boost-locale failing to build with ICU#10943
BillyONeal merged 6 commits intomicrosoft:masterfrom
Victor-Bergman:master

Conversation

@Victor-Bergman
Copy link
Contributor

@Victor-Bergman Victor-Bergman commented Apr 21, 2020

Get boost-locale to link with ICU library

@msftclas
Copy link

msftclas commented Apr 21, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@LilyWangL LilyWangL changed the title Fix boost-locale failing to build with ICU [boost-locale] Fix boost-locale failing to build with ICU Apr 21, 2020
NancyLi1013
NancyLi1013 suggested changes Apr 21, 2020
View reviewed changes
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 21, 2020

Hi @Victor-Bergman
Thanks for this PR.
Could you please also bump the version as 1.72.0-1 in CONTROL file?

@Victor-Bergman
Copy link
Contributor Author

Victor-Bergman commented Apr 21, 2020

After making the 2 changes from the review (remove include and move PATCHES), the tests on linux and OSX fail (above). These were passing last night and it makes no sense that these 2 changes should cause them to fail.

@ras0219-msft
Copy link
Contributor

ras0219-msft commented Apr 21, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 21, 2020

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 23, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 23, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 27, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 27, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY mentioned this pull request Apr 28, 2020
Merged
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 30, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 30, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 30, 2020

Need to test feature.

@JackBoosY
Copy link
Contributor

JackBoosY commented May 6, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 6, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 mentioned this pull request May 7, 2020
Closed
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented May 7, 2020

Feature has passed on the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed Needs Testing labels May 7, 2020
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented May 8, 2020

@Victor-Bergman
Could you please help confirm if this can work on static build? Or is there something that needs to be configured separately?

@strega-nil strega-nil added waiting for response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels May 8, 2020
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented May 14, 2020

@Victor-Bergman
Could you please resolve the conflicts?

@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label May 22, 2020
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jun 10, 2020

@Victor-Bergman
Is work still being done for this PR?

@PhoebeHui PhoebeHui mentioned this pull request Jun 23, 2020
Closed
@PhoebeHui PhoebeHui self-assigned this Jun 23, 2020
@pr8x
Copy link

pr8x commented Jun 23, 2020

Can confirm that the PR is working and fixing the icu build for boost-locale. Thanks!

@PhoebeHui
Copy link
Contributor

PhoebeHui commented Jun 23, 2020

The baseline failures should be addressed by #12067

@PhoebeHui
Copy link
Contributor

PhoebeHui commented Jun 29, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 29, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jun 29, 2020
BillyONeal
BillyONeal reviewed Jun 30, 2020
View reviewed changes
ras0219
ras0219 approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@ras0219 ras0219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version in the CONTROL file needs to be bumped -- otherwise LGTM

@PhoebeHui
Copy link
Contributor

PhoebeHui commented Jun 30, 2020

Done, @BillyONeal @vicroms, could you please help merge this PR?

@BillyONeal BillyONeal merged commit 0a5c4e4 into microsoft:master Jun 30, 2020
@IRebo IRebo mentioned this pull request Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

+2 more reviewers

@ras0219 ras0219 ras0219 approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoebeHui PhoebeHui

@NancyLi1013 NancyLi1013

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICU not detected in boost-locale

10 participants

@Victor-Bergman @msftclas @NancyLi1013 @ras0219-msft @JackBoosY @pr8x @PhoebeHui @ras0219 @BillyONeal @strega-nil