[microsoft-signalr] Add new port#10833
Merged
strega-nil merged 9 commits intomicrosoft:masterfrom May 15, 2020
Merged
Conversation
LilyWangL
changed the title
LilyWangL
suggested changes
Apr 16, 2020
BrennanConroy
force-pushed
the
brecon/signalr
branch
from
9648eab to
435cf57
Compare
BrennanConroy
commented
Apr 23, 2020
BrennanConroy
commented
Apr 24, 2020
Member
Author
|
@LilyWangL This should be good now? The Linux failure looks like an infrastructure issue. |
Contributor
Waiting for PR #11189 merge, this PR fix the CI baseline error. |
LilyWangL
added
the
info:needs-maintainer-attention
LilyWangL
approved these changes
May 12, 2020
strega-nil
suggested changes
May 12, 2020
Contributor
strega-nil
left a comment
strega-nil
left a comment
There was a problem hiding this comment.
Just a minor change here to avoid silent failures; thanks so much!
strega-nil
added
waiting for response
and removed
info:needs-maintainer-attention
Contributor
|
Awesome, thanks so much! Are you comfortable with me merging now? |
strega-nil
added
info:needs-maintainer-attention
Member
Author
|
Yes please :) Thanks for helping clean this up! |
Contributor
|
Alright, awesome! Thanks @BrennanConroy :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Adding the microsoft-signalr package to vcpkg.
@anurse @ras0219-msft