[boost-modular-build] Fix lack of arm64-linux support#10814
[boost-modular-build] Fix lack of arm64-linux support#10814strega-nil merged 7 commits intomicrosoft:masterfrom
Conversation
ddavidhahn
changed the title
|
Note, the failure for argumentum:x86-windows in the PR test 33540 seems to be a regression introduced into master. I've seen several other pipeline runs fail due to it and I don't believe this change should impact the failure of that test. |
|
@ddavidhahn, thanks for the PR, I have rerun the CI test. |
PhoebeHui
left a comment
PhoebeHui
left a comment
There was a problem hiding this comment.
The changes looks good to me, since arm64-linux triplet is not support by default now, this is not test by CI, however, users might need some failure message when they try to use custome triplet arm64-linux
|
@yurybura, would you like to review the change? |
yurybura
left a comment
yurybura
left a comment
There was a problem hiding this comment.
Please update version in ./boost-modular-build-helper/CONTROL
|
|
|
Thank you for taking a look @PhoebeHui @yurybura ! Went ahead and bumped up the version according to https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/control-files.md Please let me know if that doesn't look right. |
|
Looks like this failed due to an issue with the build agent. I think this failure is unrelated to the change. @PhoebeHui could you re-trigger the build? I wasn't able to see an option that would allow me to self-trigger. |
|
Related to #6217 |
|
@yurybura @PhoebeHui Are there any additional concerns with checking this in? I think it's a relatively small impact change. |
|
@PhoebeHui Gentle ping on this. Any reasons not to merge it? :) |
|
@ras0219-msft Could you take a look this PR? Thanks. |
|
Gentle ping on this @ras0219-msft |
LilyWangL
added
the
info:needs-maintainer-attention
|
Cool, LGTM :) Thanks @ddavidhahn |
7 participants
This PR fixes this issue: #8644
This change updates boost modular build to utilize x64-linux build tools when building arm64-linux. Prior to this change, running boost-modular-build.cmake for arm64-linux would result in an error message suggesting the user installs x86-windows tools which are not available on Linux machines.
Note that arm64-linux here refers to a triplet which sets VCPKG_TARGET_ARCHITECTURE to "arm64" and VCPKG_CMAKE_SYSTEM_NAME to "Linux".