[msys2 add] disable-download-timeout & overwrite#10782
[msys2 add] disable-download-timeout & overwrite#10782MVoz wants to merge 1 commit intomicrosoft:masterfrom MVoz:disable-download-timeout--overwrite
Conversation
|
@strega-nil, could you help futhre review? |
| ) | ||
| _execute_process( | ||
| COMMAND ${PATH_TO_ROOT}/usr/bin/bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman -Syu --noconfirm" | ||
| COMMAND ${PATH_TO_ROOT}/usr/bin/bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman -Syuu --noconfirm --disable-download-timeout --overwrite '*'" |
There was a problem hiding this comment.
What's -Syuu? I couldn't find mention on pacman's manpage.
There was a problem hiding this comment.
-Syuu - full update
although I don't know how the "CI" will behave, a BASH reload may be required
There was a problem hiding this comment.
Could you add a timeout to _execute_process, and just set it to like... I dunno, an hour or something?
There was a problem hiding this comment.
It's not required, with a full update can update itself BASH, pacman
When the bash is running, you get a message that you need to restart it to successfully upgrade
or you're about another?
There was a problem hiding this comment.
I mean, we don't want to just not timeout if there's an infinite loop somewhere.
There was a problem hiding this comment.
unfortunately i cannot edit
add
_execute_process(
COMMAND ${PATH_TO_ROOT}/usr/bin/bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman -Syuu --noconfirm --disable-download-timeout --overwrite '*'"
WORKING_DIRECTORY ${TOOLPATH}
)
_execute_process(
COMMAND ${CMAKE_COMMAND} -E sleep 3600#sec.
)
file(WRITE "${TOOLPATH}/${STAMP}" "0")
or
function(sleep delay)
execute_process(
COMMAND ${CMAKE_COMMAND} -E sleep ${delay}
RESULT_VARIABLE result
)
if(NOT result EQUAL 0)
message(FATAL_ERROR "failed to sleep for ${delay} second.")
endif()
endfunction(sleep)
sleep(3600)
There was a problem hiding this comment.
I mean you can do:
_execute_process(
COMMAND ${PATH_TO_ROOT}/usr/bin/bash.exe --noprofile --norc -c "PATH=/usr/bin;pacman -Syuu --noconfirm --disable-download-timeout --overwrite '*'"
TIMEOUT 3600
)There was a problem hiding this comment.
tested, works locally, not on the VMSS (cannot remove /usr/bin/pacman.exe (Permission denied))
errors associated with junction/symlink and access rights
close
+add full update dist