Skip to content

[libarchive, libuv]Fix static linkage#10769

Merged
ras0219-msft merged 6 commits intomicrosoft:masterfrom
Neumann-A:fix_libarchive_libuv_static_linkage
Apr 17, 2020
Merged

[libarchive, libuv]Fix static linkage#10769
ras0219-msft merged 6 commits intomicrosoft:masterfrom
Neumann-A:fix_libarchive_libuv_static_linkage

Conversation

@Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Apr 10, 2020

adds a wrapper to correctly link in dependencies for libarchive and libuv

@Neumann-A Neumann-A changed the title []Fix libarchive libuv static linkage [libarchive, libuv]Fix static linkage Apr 10, 2020
@LilyWangL
Copy link
Contributor

include(vcpkg_common_functions) is deprecated in libuv/portfile.cmake. Please remove it.

@LilyWangL LilyWangL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Apr 14, 2020
@LilyWangL LilyWangL added waiting for response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Apr 17, 2020
@LilyWangL LilyWangL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Apr 17, 2020
@ras0219-msft ras0219-msft merged commit 4d8237b into microsoft:master Apr 17, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks!

@Neumann-A Neumann-A deleted the fix_libarchive_libuv_static_linkage branch April 18, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants