Skip to content

[coroutine] update to 1.5.0#10692

Merged
ras0219-msft merged 6 commits intomicrosoft:masterfrom
luncliff:master
Apr 24, 2020
Merged

[coroutine] update to 1.5.0#10692
ras0219-msft merged 6 commits intomicrosoft:masterfrom
luncliff:master

Conversation

@luncliff
Copy link
Contributor

@luncliff luncliff commented Apr 4, 2020 •
edited
Loading

Changes

New release which allows x86 with better documentation

Related Issues

Support

Triplet/Compiler

The followings are tested with CI / Local environment

  • x64-windows: MSVC (vc141, vc142)
  • x86-windows: MSVC (vc141, vc142)
  • x64-windows-static: MSVC (vc141, vc142)
  • x86-windows-static: MSVC (vc141, vc142)
  • x64-osx: AppleClang 11
  • x64-linux: Clang 8.0.1+, GCC 10.0.1

@luncliff
[coroutine] update to 1.5.0
1a807ce 
* this is release candidate
* WindowsStore build will be updated soon
@luncliff
Copy link
Contributor Author

luncliff commented Apr 4, 2020 •
edited
Loading

(Updated) Triplet WindowsStore build will be updated within this weekend

Support

Triplet/Compiler

Tested with VS 2019

  • x86-uwp: MSVC (vc142)
  • x64-uwp: MSVC (vc142)
  • arm64-windows: MSVC (vc142)
  • arm-uwp: MSVC (vc142)

@luncliff
[coroutine] support UWP build
25a3c49 
* triplet(community) `x64-uwp`, `x86-uwp`
* triplet: `arm-uwp`, `arm64-windows`
NancyLi1013
NancyLi1013 suggested changes Apr 7, 2020
View reviewed changes
ports/coroutine/portfile.cmake Outdated
@@ -1,38 +1,38 @@
include(vcpkg_common_functions)
Copy link
Contributor

@NancyLi1013 NancyLi1013 Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is no longer needed.
Could you please remove it?

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 7, 2020

/azp run

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 7, 2020

Hi @luncliff
Thanks for this PR.
It seems that coroutine currently doesn't support uwp and linux.
If so, could you please add Supports: !(uwp|linux) to CONTROL file and add vcpkg_fail_port_install(ON_TARGET "uwp" "linux") to portfile.cmake?

@luncliff
Copy link
Contributor Author

luncliff commented Apr 7, 2020

Hi @luncliff
Thanks for this PR.
It seems that coroutine currently doesn't support uwp and linux.
If so, could you please add Supports: !(uwp|linux) to CONTROL file and add vcpkg_fail_port_install(ON_TARGET "uwp" "linux") to portfile.cmake?

UWP install was fine with my laptop, but seems like I missed something.
I will take a look at it.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 8, 2020

Ok. Thanks for your update.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 16, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 16, 2020

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 16, 2020

Could you please also try to fix the regressions on Windows and OSX?

@luncliff
Copy link
Contributor Author

luncliff commented Apr 16, 2020

Could you please also try to fix the regressions on Windows and OSX?

Sorry @NancyLi1013 . I was quite busy. Will update ASAP.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 16, 2020

Okay, thanks for your update.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 17, 2020

I noticed that it has passed on x86-windows.
Could you please remove coroutine:x86-windows=fail from baseline?

@luncliff
Copy link
Contributor Author

luncliff commented Apr 17, 2020

@NancyLi1013 Sure. I will update the part after Linux/OSX build reports their ends.

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Apr 22, 2020
@ras0219-msft
Copy link
Contributor

ras0219-msft commented Apr 24, 2020

Thanks for making a neat library and submitting this update PR!

I relaxed some of the restrictions around Linux; here's a brief idea of how they should be used:

  • The Supports: field should be optimistic -- if there is a way to use it on Linux (via clang, libc++, etc), it shouldn't be listed as unsupported
  • vcpkg_fail_port_install() should similarly be optimistic
  • scripts/ci.baseline.txt must exactly match our specific CI setup; if we aren't using the right GCC version in CI, then it gets marked as failing here

This ensures that users who opt in to jumping through the appropriate hoops (having GCC 10, etc) can access those niche scenarios with vcpkg.

@ras0219-msft ras0219-msft merged commit 7fbb196 into microsoft:master Apr 24, 2020
luncliff
luncliff commented Apr 25, 2020
View reviewed changes
Copy link
Contributor Author

@luncliff luncliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

learned a lot from this. Thanks :D

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Apr 26, 2020

@luncliff
Thanks for your kindly reminder.
I closed it just now.

@luncliff luncliff mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luncliff @NancyLi1013 @ras0219-msft