[vcpkg] Fix nuget/aria2/ninja version/filename inconsistent#10655
Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom Apr 6, 2020
Merged
[vcpkg] Fix nuget/aria2/ninja version/filename inconsistent#10655dan-shaw merged 1 commit intomicrosoft:masterfrom
dan-shaw merged 1 commit intomicrosoft:masterfrom
Conversation
…filename inconsistent
PhoebeHui
added
the
info:needs-maintainer-attention
Contributor
|
https://github.com/ninja-build/ninja/releases
? |
JackBoosY
approved these changes
Apr 3, 2020
Contributor
Author
This PR fix issue #10655. Ninja will update to new version by other PRs. |
Contributor
|
why you can't update the version right away, what are the difficulties in this? |
Contributor
|
Going to merge this to fix the immediate issue. For updating Ninja, we can open another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Fix nuget/aria2/ninja in vcpkgTools.xml, vcpkg_find_acquire_program.cmake version/filename inconsistent
What does your PR fix? Fixes issue vcpkgTools.xml, vcpkg_find_acquire_program.cmake version/filename inconsistent #10625
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?