Skip to content

[abseil] Fix feature name error#10620

Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom
LilyWangL:dev/Lily/pr8248
Apr 3, 2020
Merged

[abseil] Fix feature name error#10620
dan-shaw merged 1 commit intomicrosoft:masterfrom
LilyWangL:dev/Lily/pr8248

Conversation

@LilyWangL
Copy link
Copy Markdown
Contributor

@LilyWangL LilyWangL commented Mar 31, 2020

Modify feature name c++17 to cxx17, fix the error:

Error: <unknown>:1:9: invalid character in feature name (must be lowercase, digits, '-', or '*')
   on expression: "abseil[c++17]"

The related PR: #8248

@LilyWangL LilyWangL requested a review from JackBoosY March 31, 2020 09:14
@LilyWangL LilyWangL mentioned this pull request Mar 31, 2020
Merged
@JackBoosY JackBoosY marked this pull request as ready for review April 1, 2020 06:06
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Apr 1, 2020

Needs to wait to resolve the osg-qt regression in #10637.

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Apr 2, 2020

/azp run

@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 2, 2020
@dan-shaw dan-shaw merged commit 32d29d6 into microsoft:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LilyWangL @JackBoosY @dan-shaw