[civetweb] Update to version 1.12#10591
Merged
strega-nil merged 1 commit intomicrosoft:masterfrom May 1, 2020
Merged
Conversation
Cheney-W
suggested changes
Mar 30, 2020
Contributor
Cheney-W
left a comment
Cheney-W
left a comment
There was a problem hiding this comment.
Thanks for your PR!
include(vcpkg_common_functions)is no longer needed, could you please remove this line?- Could you please modify
if(VCPKG_CMAKE_SYSTEM_NAME STREQUAL "WindowsStore")
message(FATAL_ERROR "${PORT} does not currently support UWP")
endif()
as below:
vcpkg_fail_port_install(MESSAGE "${PORT} does not currently support UWP" ON_TARGET "UWP") - Could you please modify
configure_file(${SOURCE_PATH}/LICENSE.md ${CURRENT_PACKAGES_DIR}/share/civetweb/copyright COPYONLY)
as below:
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)
Contributor
Author
|
Thanks for the review. I addressed all of your comments and re-tested locally. |
Contributor
|
@gjasny |
Contributor
Author
|
@Cheney-W done |
Contributor
|
@gjasny Thanks for your PR. I have tested this PR on Linux and MACOS, and it passed. Please remove the below lines from |
Cheney-W
approved these changes
Apr 1, 2020
Contributor
|
@gjasny Could you address Lily's suggestion? Thanks! |
Contributor
Author
|
Sorry, I must have missed the notification email. |
Cheney-W
added
info:needs-maintainer-attention
Contributor
|
Alright, this looks great! Thanks @gjasny :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update civetweb from snapshot release to regular 1.12 release. Tested locally on MacOS against prometheus-cpp.