[sdl2-gfx] Fix build error on non windows#10575
Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom Apr 24, 2020
Merged
[sdl2-gfx] Fix build error on non windows#10575ras0219-msft merged 3 commits intomicrosoft:masterfrom
ras0219-msft merged 3 commits intomicrosoft:masterfrom
Conversation
JackBoosY
approved these changes
Mar 27, 2020
JackBoosY
added
the
info:needs-maintainer-attention
dan-shaw
reviewed
Mar 28, 2020
dan-shaw
added
waiting for response
and removed
info:needs-maintainer-attention
Contributor
|
Needs to wait to resolve the osg-qt regression in #10637. |
JackBoosY
approved these changes
Apr 1, 2020
Contributor
|
/azp run |
JackBoosY
approved these changes
Apr 16, 2020
JackBoosY
added
the
info:needs-maintainer-attention
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows.his only needed on Windows platform.So I updated it only when
WIN32, the related definitions could be added.Other changes:
include(vcpkg_common_functions)Supports: widowsfield toCONTROLfileRelated issue #10570
Note: No features need to test.