[blitz] Update to the latest commit and fix no dll and lib generated#10546
Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom Mar 28, 2020
Merged
[blitz] Update to the latest commit and fix no dll and lib generated#10546dan-shaw merged 2 commits intomicrosoft:masterfrom
dan-shaw merged 2 commits intomicrosoft:masterfrom
Conversation
|
Dear @NancyLi1013 how can try to install Blitz via vcpkg with this PR? |
|
Done, I directly changed the value in my And....... it works!! The DLL and library (static and dynamic) are properly copied at good places. |
|
Tested for x64-windows, installed is OK. |
|
Finally it passed for x86-windows, the first there was an error about the write operation around So it is OK under Windows 10, with standard tools provided by vcpkg (CMake 3.14.0 + Python 2.7.16) |
Contributor
Author
|
/azp run |
PhoebeHui
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are no dlls or libs generated by
blitzcurrent version on Windows platform in vcpkg.So I update this port to the latest commit to fix this issue.
Related issue #10531
Note: No features need to test.