Skip to content

[curlpp] Fix target "curlpp" link "ZLIB::ZLIB" error#10535

Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom
LilyWangL:dev/Lily/issue10525
Apr 16, 2020
Merged

[curlpp] Fix target "curlpp" link "ZLIB::ZLIB" error#10535
ras0219-msft merged 4 commits intomicrosoft:masterfrom
LilyWangL:dev/Lily/issue10525

Conversation

@LilyWangL
Copy link
Contributor

@LilyWangL LilyWangL commented Mar 24, 2020

Describe the pull request
Add zlib to default feature, fix curlpp build failed with this error:

CMake Error at D:/Git/vs2019.prod/scripts/buildsystems/vcpkg.cmake:217 (_add_library):
Target "curlpp" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
CMakeLists.txt:89 (add_library)

@JackBoosY
Copy link
Contributor

JackBoosY commented Mar 26, 2020

/azp run

@LilyWangL LilyWangL marked this pull request as ready for review March 27, 2020 02:35
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 27, 2020
dan-shaw
dan-shaw reviewed Mar 28, 2020
View reviewed changes
@dan-shaw dan-shaw added waiting for response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 28, 2020
@PhoebeHui PhoebeHui mentioned this pull request Apr 7, 2020
Closed
@Neumann-A
Copy link
Contributor

Neumann-A commented Apr 7, 2020

Please change this PR to use the fix discussed in #10715. The problem is not with curl but with curlpp not setting cmake_minimum_required() before the first project() call.

@LilyWangL LilyWangL changed the title [curl] Add zlib to default feature [curlpp] Fix target "curlpp" link "ZLIB::ZLIB" error Apr 7, 2020
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Apr 9, 2020
@JackBoosY JackBoosY mentioned this pull request Apr 13, 2020
Merged
@ras0219-msft ras0219-msft merged commit 4b8ad78 into microsoft:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@dan-shaw dan-shaw dan-shaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LilyWangL @JackBoosY @Neumann-A @dan-shaw @ras0219-msft