Skip to content

[avro-c] Fix building avro-c in Linux#10514

Merged
ras0219-msft merged 4 commits intomicrosoft:masterfrom
mispecto:avro_c_linux
Apr 16, 2020
Merged

[avro-c] Fix building avro-c in Linux#10514
ras0219-msft merged 4 commits intomicrosoft:masterfrom
mispecto:avro_c_linux

Conversation

@mispecto
Copy link
Contributor

This PR fixes Avro for C compilation in Linux (issue #10339 ).

Changes:

  • Fix finding debug versions of liblzma, libsnappy and jansson
  • Link with standard C++ library when Snappy is added as reference (it's written in C++).

@kreuzerkrieg
Copy link
Contributor

looks like it should build on OSX too now, am I wrong?

@mispecto
Copy link
Contributor Author

looks like it should build on OSX too now, am I wrong?

Probably, but I don't have Mac in my possession to check this :)

@kreuzerkrieg
Copy link
Contributor

Me neither, let the CI test it :)

@LilyWangL LilyWangL self-assigned this Mar 24, 2020
@mispecto
Copy link
Contributor Author

Me neither, let the CI test it :)

BTW, do you know why the CI fails for every platform? I can't find a meaningful log that explains the failure..

@kreuzerkrieg
Copy link
Contributor

Me neither, let the CI test it :)

BTW, do you know why the CI fails for every platform? I can't find a meaningful log that explains the failure..

Looks like they have problems with the CI. Again.
Usually when they resolve the problem they re-run the CI. Just lets wait for @LilyWangL to take care of it

@LilyWangL
Copy link
Contributor

Me neither, let the CI test it :)

BTW, do you know why the CI fails for every platform? I can't find a meaningful log that explains the failure..

Looks like they have problems with the CI. Again.
Usually when they resolve the problem they re-run the CI. Just lets wait for @LilyWangL to take care of it

Waiting for the PR #10508 merged, this PR will fix the CI test.

@LilyWangL
Copy link
Contributor

/azp run

@LilyWangL
Copy link
Contributor

@spektom Thanks for your PR, please modify ci.baseline.txt to account for the Linux failures. Remove the following code in VCPKG_PATH/scripts/ci.baseline.txt:

avro-c:x64-linux=fail

@mispecto
Copy link
Contributor Author

@spektom Thanks for your PR, please modify ci.baseline.txt to account for the Linux failures. Remove the following code in VCPKG_PATH/scripts/ci.baseline.txt:

avro-c:x64-linux=fail

Done.

@LilyWangL LilyWangL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Mar 30, 2020
@kreuzerkrieg
Copy link
Contributor

bump

1 similar comment
@kreuzerkrieg
Copy link
Contributor

bump

@PhoebeHui PhoebeHui changed the title Fix building avro-c in Linux [avro-c] Fix building avro-c in Linux Apr 13, 2020
@PhoebeHui PhoebeHui self-assigned this Apr 13, 2020
@ras0219-msft ras0219-msft merged commit 6483965 into microsoft:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants