[libffi] Support arm/arm64#10485
Merged
dan-shaw merged 5 commits intomicrosoft:masterfrom Apr 6, 2020
Merged
Conversation
Contributor
|
Could somebody pls. clarify why Also please note that |
derselbst
reviewed
Mar 22, 2020
Contributor
Author
|
/azp run |
This was referenced Mar 26, 2020
Contributor
Author
|
/azp run |
Contributor
Author
|
/azp run |
PhoebeHui
approved these changes
Apr 3, 2020
PhoebeHui
added
the
info:needs-maintainer-attention
derselbst
added a commit
to FluidSynth/fluidsynth
that referenced
this pull request
Apr 8, 2020
For some reason, the configure command must be specified explicitly in the `gentables` build step. Otherwise, the ARM target compiler will be used to build `make_tables` rather than the host compiler. Now that microsoft/vcpkg#10485 has been completed, an ARM CI build can be added to AppVeyor. Also, the build status table in the README has been updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix arm/arm64 build, pass the correct arm / arm64 parameters to cmake.
Related: #10469.