[spdlog] Update to 1.6.0

[Sil3ntStorm]

Describe the pull request

• What does your PR fix? Fixes issue #

• Which triplets are supported/not supported? Have you updated the CI baseline?

• Does your PR follow the maintainer guide?

[msftclas]

All CLA requirements met.

[Sil3ntStorm]

CI failures appear to be caused by some issue on Azure?

[NancyLi1013]

The regressions caused by other ports have been fixing in this PR #10508.

[NancyLi1013]

/azp run

[NancyLi1013]

Could you please try to look into the regressions on Windows platform?
You can get the log here .

[Sil3ntStorm]

Failure is in the azure-kinect-sensor-sdk port. Not sure why that is even built, attempted, or reported as I didn't touch that but yeah.

[Sil3ntStorm]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 10471 in repo microsoft/vcpkg

[NancyLi1013]

/azp run

[Sil3ntStorm]

Not going to fix any of the third party stuff that is causing these CI failures.

[NancyLi1013]

/azp run

[azure-pipelines]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

[NancyLi1013]

Since azure-kinect-sensor-sdk depends on spdlog.
This regression on x64-windows-static caused by azure-kinect-sensor-sdk is related with this PR.
Could you please look into it?

optimized;C:/vsts/_work/4/s/installed/x64-windows-static/lib/jpeg.lib;debug;C:/vsts/_work/4/s/installed/x64-windows-static/debug/lib/jpegd.lib (found version "62") 
-- Looking for pthread.h
-- Looking for pthread.h - not found
-- Found Threads: TRUE  
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed
-- Performing Test COMPILER_HAS_DEPRECATED
-- Performing Test COMPILER_HAS_DEPRECATED - Success
-- Clang-format not found
CMake Error at CMakeLists.txt:303 (configure_file):
  configure_file Problem configuring file

[NancyLi1013]

Related issue #10931

[Sil3ntStorm]

This is an issue with CI #worksonmymachine

./vcpkg.exe install azure-kinect-sensor-sdk --triplet x64-windows-static
Installing package azure-kinect-sensor-sdk[core]:x64-windows-static... done

./vcpkg.exe list
azure-c-shared-utility:x64-windows-static          2020-02-04.1     Azure C SDKs common code
azure-kinect-sensor-sdk:x64-windows-static         1.4.0-alpha.0-2  Azure Kinect SDK is a cross platform (Linux and ...
azure-macro-utils-c:x64-windows-static             2020-02-04.1     A library of macros for the Azure IoT SDK Suite
cjson:x64-windows-static                           2019-11-30       Ultralightweight JSON parser in ANSI C
ebml:x64-windows-static                            1.3.10           a C++ libary to parse EBML files
fmt:x64-windows-static                             6.1.2            Formatting library for C++. It can be used as a ...
glfw3:x64-windows-static                           3.3.2            GLFW is a free, Open Source, multi-platform libr...
gtest:x64-windows-static                           2019-10-09-1     GoogleTest and GoogleMock testing frameworks.
imgui:x64-windows-static                           1.74             Bloat-free Immediate Mode Graphical User interfa...
libjpeg-turbo:x64-windows-static                   2.0.4            libjpeg-turbo is a JPEG image codec that uses SI...
libsoundio:x64-windows-static                      2.0.0-3          libsoundio is C library providing cross-platform...
libusb:x64-windows-static                          1.0.23           a cross-platform library to access USB devices
libyuv:x64-windows-static                          fec9121-1        libyuv is an open source project that includes Y...
matroska:x64-windows-static                        1.5.2            a C++ libary to parse Matroska files (.mkv and ....
spdlog:x64-windows-static                          1.5.0            Very fast, header only, C++ logging library
umock-c:x64-windows-static                         2020-02-04.1     A pure C mocking library

git status
On branch update/spdlog
Your branch is up to date with 'origin/update/spdlog'.

nothing to commit, working tree clean

[NancyLi1013]

Thanks for your update @Sil3ntStorm.

@ras0219-msft
Could you help take a look about this?

It seems that there is something wrong with CI machine.
I also cannot reproduce this on my local.
I noticed the problem is here:

# Generate .NET Version file.
configure_file(VersionInfo.cs.in ${CMAKE_CURRENT_SOURCE_DIR}/src/csharp/VersionInfo.cs)

But I don't know what happened.

[Sil3ntStorm]

Yes, that's also why I was like it makes no sense to fail like that.
For all I know, it's just supposed to copy that file into the other location and replace some text in it if needed. It doesn't even seem to have anything to do with any code.
Why would that fail, unless maybe the disk is full?

[NancyLi1013]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Sil3ntStorm]

CMake Error: Could not open file for write in copy operation C:/agent/_work/1/s/buildtrees/azure-kinect-sensor-sdk/src/11aa54ede6-616869ab19/src/csharp/k4a.x64.props.tmp
CMake Error: : System Error: Permission denied

I see CI is still not doing what it's supposed to...

[JackBoosY]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JackBoosY]

LGTM now, testing...

[NancyLi1013]

It seems that only feature fmt can be built now.

@Sil3ntStorm
Could you please help confirm if spdlog currently only supports feature fmt?

If other features are not supported, it might be better to remove them.

[Sil3ntStorm]

@NancyLi1013 I don't even know what you're talking about. Note that I stopped trusting the absolut clusterf* of CI you got running here and also stopped bothering looking at the results, they're always bogus anyway.

[sylveon]

They're present in the released CMakeLists.txt
https://github.com/gabime/spdlog/blob/cf6f1dd01e660d5865d68bf5fa78f6376b89470a/CMakeLists.txt#L52-L93

[NancyLi1013]

@Sil3ntStorm
I'm so sorry about this.
I want to make it clarify that the above results are not from CI test. Since CI doesn't support test for any features now. So we need to test them manually.

As for the CI test for this port, all checks are good. We have switched the CI test to microsoft.vcpkg.pr(triplet). So we just need to care about the results here.

I'm so sorry that I haven't describe this correctly before this.

[NancyLi1013]

@Sil3ntStorm
Are you willing to update spdlog to 1.6.0?

[Sil3ntStorm]

there you go. Any bets as to whether they'll release 1.7.0 before this PR is done?

[NancyLi1013]

@Sil3ntStorm
Thanks so much for your continuous work to this PR.

Sorry, I don't know any plan for spdlog release.

I will test these features as soon as possible.

[NancyLi1013]

@Sil3ntStorm
There are two problems that need to confirm with you.

Could you please help check this?

The feature benchmark build failed on Windows due to this:

F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(103): error C2664: 'std::shared_ptr<spdlog::logger> spdlog::basic_logger_st<spdlog::synchronous_factory>(const std::string &,const spdlog::filename_t &,bool)': cannot convert argument 2 from 'const char [26]' to 'const spdlog::filename_t &'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(103): note: Reason: cannot convert from 'const char [26]' to 'const spdlog::filename_t'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(103): note: No constructor could take the source type, or constructor overload resolution was ambiguous
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(104): error C3536: 'basic_st': cannot be used before it is initialized
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(107): error C2664: 'std::shared_ptr<spdlog::logger> spdlog::basic_logger_st<spdlog::synchronous_factory>(const std::string &,const spdlog::filename_t &,bool)': cannot convert argument 2 from 'const char [34]' to 'const spdlog::filename_t &'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(107): note: Reason: cannot convert from 'const char [34]' to 'const spdlog::filename_t'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(107): note: No constructor could take the source type, or constructor overload resolution was ambiguous
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(108): error C3536: 'tracing_basic_st': cannot be used before it is initialized
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(113): error C2664: 'std::shared_ptr<spdlog::logger> spdlog::rotating_logger_st<spdlog::synchronous_factory>(const std::string &,const spdlog::filename_t &,size_t,size_t,bool)': cannot convert argument 2 from 'const char [29]' to 'const spdlog::filename_t &'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(113): note: Reason: cannot convert from 'const char [29]' to 'const spdlog::filename_t'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(113): note: No constructor could take the source type, or constructor overload resolution was ambiguous
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(114): error C3536: 'rotating_st': cannot be used before it is initialized
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(118): error C2664: 'std::shared_ptr<spdlog::logger> spdlog::rotating_logger_st<spdlog::synchronous_factory>(const std::string &,const spdlog::filename_t &,size_t,size_t,bool)': cannot convert argument 2 from 'const char [37]' to 'const spdlog::filename_t &'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(118): note: Reason: cannot convert from 'const char [37]' to 'const spdlog::filename_t'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(118): note: No constructor could take the source type, or constructor overload resolution was ambiguous
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(119): error C3536: 'tracing_rotating_st': cannot be used before it is initialized
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(123): error C2664: 'std::shared_ptr<spdlog::logger> spdlog::daily_logger_mt<spdlog::synchronous_factory>(const std::string &,const spdlog::filename_t &,int,int,bool,uint16_t)': cannot convert argument 2 from 'const char [26]' to 'const spdlog::filename_t &'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(123): note: Reason: cannot convert from 'const char [26]' to 'const spdlog::filename_t'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(123): note: No constructor could take the source type, or constructor overload resolution was ambiguous
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(124): error C3536: 'daily_st': cannot be used before it is initialized
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(126): error C2664: 'std::shared_ptr<spdlog::logger> spdlog::daily_logger_mt<spdlog::synchronous_factory>(const std::string &,const spdlog::filename_t &,int,int,bool,uint16_t)': cannot convert argument 2 from 'const char [26]' to 'const spdlog::filename_t &'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(126): note: Reason: cannot convert from 'const char [26]' to 'const spdlog::filename_t'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(126): note: No constructor could take the source type, or constructor overload resolution was ambiguous
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(127): error C3536: 'tracing_daily_st': cannot be used before it is initialized
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(137): error C2664: 'std::shared_ptr<spdlog::logger> spdlog::basic_logger_mt<spdlog::synchronous_factory>(const std::string &,const spdlog::filename_t &,bool)': cannot convert argument 2 from 'const char [26]' to 'const spdlog::filename_t &'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(137): note: Reason: cannot convert from 'const char [26]' to 'const spdlog::filename_t'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(137): note: No constructor could take the source type, or constructor overload resolution was ambiguous
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(138): error C3536: 'basic_mt': cannot be used before it is initialized
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(142): error C2664: 'std::shared_ptr<spdlog::logger> spdlog::rotating_logger_mt<spdlog::synchronous_factory>(const std::string &,const spdlog::filename_t &,size_t,size_t,bool)': cannot convert argument 2 from 'const char [29]' to 'const spdlog::filename_t &'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(142): note: Reason: cannot convert from 'const char [29]' to 'const spdlog::filename_t'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(142): note: No constructor could take the source type, or constructor overload resolution was ambiguous
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(143): error C3536: 'rotating_mt': cannot be used before it is initialized
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(147): error C2664: 'std::shared_ptr<spdlog::logger> spdlog::daily_logger_mt<spdlog::synchronous_factory>(const std::string &,const spdlog::filename_t &,int,int,bool,uint16_t)': cannot convert argument 2 from 'const char [26]' to 'const spdlog::filename_t &'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(147): note: Reason: cannot convert from 'const char [26]' to 'const spdlog::filename_t'
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(147): note: No constructor could take the source type, or constructor overload resolution was ambiguous
F:\10471\vcpkg\buildtrees\spdlog\src\b3f2120671-8e307892b3\bench\latency.cpp(148): error C3536: 'daily_mt': cannot be used before it is initialized

In addition, it seems that we need to add the following codes to handle the dll files generated in static build:

if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
        file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/debug/bin")
endif()

[NancyLi1013]

Related PR #11793

@Sil3ntStorm
Is work still being done for this PR?

[NancyLi1013]

Thanks for the PR; we're closing this for now since there's been no response. If you'd like to continue working on it, please reopen and ping us!